From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22736 invoked by alias); 6 Oct 2006 20:39:16 -0000 Received: (qmail 22726 invoked by uid 22791); 6 Oct 2006 20:39:15 -0000 X-Spam-Check-By: sourceware.org Received: from nile.gnat.com (HELO nile.gnat.com) (205.232.38.5) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 06 Oct 2006 20:39:08 +0000 Received: from localhost (localhost [127.0.0.1]) by filtered-nile.gnat.com (Postfix) with ESMTP id 62EE248CE4B for ; Fri, 6 Oct 2006 16:39:06 -0400 (EDT) Received: from nile.gnat.com ([127.0.0.1]) by localhost (nile.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 18764-02-3 for ; Fri, 6 Oct 2006 16:39:06 -0400 (EDT) Received: from takamaka.act-europe.fr (unknown [70.71.0.212]) by nile.gnat.com (Postfix) with ESMTP id E177F48CDAE for ; Fri, 6 Oct 2006 16:39:05 -0400 (EDT) Received: by takamaka.act-europe.fr (Postfix, from userid 507) id AFE4847F00; Fri, 6 Oct 2006 13:39:04 -0700 (PDT) Date: Fri, 06 Oct 2006 20:39:00 -0000 From: Joel Brobecker To: gdb-patches@sources.redhat.com Subject: Re: [RFA/dwarf2] Fix PR/2018 - set array type names Message-ID: <20061006203904.GA1059@adacore.com> References: <20061006192303.GA1095@adacore.com> <20061006192758.GA15058@nevyn.them.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20061006192758.GA15058@nevyn.them.org> User-Agent: Mutt/1.4i Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-10/txt/msg00067.txt.bz2 > I don't think I looked at this the first time you sent it. The hack is > disgusting, but that's a problem for another day. I think the comment > in GCC is simply incorrect for DWARF-2, and the array should have the > correct range type. I am not sure which hack you refer to; if you're talking about the encoding we're using, I also agree that it's not very elegant. It's a artifact that comes from old times when dwarf2 wasn't available (and still isn't always available on certain targets). However, we *are* at AdaCore working on producing more standard dwarf, so eventually the array index should have the correct type. We've made some progress in that direction already, but it will take a LOT of work to complete. > > 2006-10-06 Joel Brobecker > > > > * dwarf2read.c (read_array_type): Set the type name if the name > > attribute is present. > > > > Tested on x86-linux, fixes the 4 KFAILs of gdb.ada/arrayidx.exp, no > > regression. OK to commit? > > OK. Thanks! Will commit shortly, and then remove the KFAILs. -- Joel