Re: [RFA] Fix frame-issue with watchpoints...

[Joel Brobecker <brobecker@adacore.com>]

> > The issue in our case is that "current_frame" is NULL too, probably
> > because we never needed it before in our case (just finished off
> > single-stepping out of the breakpoint and immediately getting ready
> > to resume) and therefore never set it to a proper value.
> 
> This is 100% bogus.  If we leave this code at all, we should absolutely
> do this:
> 
> > One way to bandaid this, probably along the lines that Andrew was
> > trying to do (try to recover from a situation that should not happen),
> > is to replace "current_frame" by get_current_frame().
> 
> Or just kill it.

Let me do a testsuite run without this code, and see what comes out
of it. Perhaps it's time to kill it.

> is also right.  Except that you really scared me here: you are actually
> starting from the _innermost_ frame, not the _outermost_.

Argh, yes, of course! I keep thinking the wrong way when I don't pay
attention. Sorry.

> > 2006-10-05  Joel Brobecker  <brobecker@adacore.com>
> > 
> >         * blockframe.c (block_innermost_frame): Rewrite frame search logic.
> > 
> > Tested on x86-linux, no regression. A new testcase to be submitted soon.
> > OK to apply?
> 
> OK.

Thanks, now applied. (and thanks for the lightning-fast review, it is
always very much appreciated)

-- 
Joel