From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: brobecker@adacore.com
Cc: gdb-patches@sources.redhat.com
Subject: Re: [RFA/HPUX] somread.c: avoid stack overflow
Date: Wed, 04 Oct 2006 19:32:00 -0000 [thread overview]
Message-ID: <200610041932.k94JWBpG012851@elgar.sibelius.xs4all.nl> (raw)
In-Reply-To: <20061004182505.GH23247@adacore.com> (message from Joel Brobecker on Wed, 4 Oct 2006 11:25:05 -0700)
> Date: Wed, 4 Oct 2006 11:25:05 -0700
> From: Joel Brobecker <brobecker@adacore.com>
>
> Hello,
>
> A customer of ours ran into a GDB crash that was caused by a stack
> overflow. Their executables are very large, and it turned out when
> we started debugging that the overflow happened during an alloca
> besides which there already was a FIXME:.
>
> We replace the calls to alloca by a call to xmalloc followed by
> make_cleanup and the problem was gone.
>
> 2006-10-04 Joel Brobecker <brobecker@adacore.com>
>
> * somread.c (som_symtab_read): Avoid using alloca for potentially
> large buffers.
>
> Tested on pa-hpux, no regression.
>
> OK to commit?
Looks reasonable to me.
next prev parent reply other threads:[~2006-10-04 19:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-04 18:25 Joel Brobecker
2006-10-04 19:32 ` Mark Kettenis [this message]
2006-10-04 21:38 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200610041932.k94JWBpG012851@elgar.sibelius.xs4all.nl \
--to=mark.kettenis@xs4all.nl \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox