From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28269 invoked by alias); 3 Oct 2006 19:20:11 -0000 Received: (qmail 28255 invoked by uid 22791); 3 Oct 2006 19:20:11 -0000 X-Spam-Check-By: sourceware.org Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Tue, 03 Oct 2006 19:20:05 +0000 Received: from drow by nevyn.them.org with local (Exim 4.54) id 1GUpo9-0005w4-NW; Tue, 03 Oct 2006 15:20:01 -0400 Date: Tue, 03 Oct 2006 19:20:00 -0000 From: Daniel Jacobowitz To: Janani Janakiraman Cc: gdb-patches@sourceware.org Subject: Re: [patch] Pushing Inferior Function Arguments onto Stack on PowerPC64 machines Message-ID: <20061003192001.GA22779@nevyn.them.org> Mail-Followup-To: Janani Janakiraman , gdb-patches@sourceware.org References: <4522B5E2.mailKT8130U2Q@jananij.austin.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4522B5E2.mailKT8130U2Q@jananij.austin.ibm.com> User-Agent: Mutt/1.5.13 (2006-08-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-10/txt/msg00009.txt.bz2 On Tue, Oct 03, 2006 at 02:11:30PM -0500, Janani Janakiraman wrote: > This fixes a problem on Powerpc 64 machines while running gdb on 64 bit > programs. The problem is with the alignment of the function arguments > when they are pushed to the stack in the ppc64_sysv_abi_push_dummy_call. > GCC expects the values to be right aligned. Is Andrew's comment about the ABI correct, or incorrect? Do you know for sure? > ! /* WARNING: cagney/2003-09-21: As best I can > ! tell, the ABI specifies that the value should > ! be left aligned. Unfortunately, GCC doesn't > ! do this - it instead right aligns even sized > ! values and puts odd sized values on the > ! stack. Work around that by putting both a > ! left and right aligned value into the > ! register (hopefully no one notices :-^). > ! Arrrgh! */ -- Daniel Jacobowitz CodeSourcery