From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3094 invoked by alias); 29 Sep 2006 20:57:41 -0000 Received: (qmail 3082 invoked by uid 22791); 29 Sep 2006 20:57:40 -0000 X-Spam-Check-By: sourceware.org Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Fri, 29 Sep 2006 20:57:34 +0000 Received: from drow by nevyn.them.org with local (Exim 4.54) id 1GTPQJ-00006m-Jr; Fri, 29 Sep 2006 16:57:31 -0400 Date: Fri, 29 Sep 2006 20:57:00 -0000 From: Daniel Jacobowitz To: Fred Fish Cc: GDB Patches Subject: Re: Include "defs.h" before other includes, for vec.c Message-ID: <20060929205731.GA366@nevyn.them.org> Mail-Followup-To: Fred Fish , GDB Patches References: <200609291331.42865.fnf@specifix.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200609291331.42865.fnf@specifix.com> User-Agent: Mutt/1.5.13 (2006-08-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-09/txt/msg00212.txt.bz2 On Fri, Sep 29, 2006 at 01:31:42PM -0700, Fred Fish wrote: > This fixes a problem on solaris, where vec.h causes types.h to be pulled in, > but since _SYSCALL32 hasn't been defined yet (by config.h), off32_t doesn't > get defined. Then later, defs.h pulls in config.h, which defines _SYSCALL32, > and also causes fcntl.h to be pulled in, which sees _SYSCALL32 and tries > to use off32_t, which isn't defined. > > > 2006-09-29 Fred Fish > > * vec.c: Include defs.h first. This pulls in config.h which can > affect other includes. Oops. OK, and thanks. -- Daniel Jacobowitz CodeSourcery