From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10740 invoked by alias); 21 Sep 2006 19:14:29 -0000 Received: (qmail 10727 invoked by uid 22791); 21 Sep 2006 19:14:27 -0000 X-Spam-Check-By: sourceware.org Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Thu, 21 Sep 2006 19:14:26 +0000 Received: from drow by nevyn.them.org with local (Exim 4.54) id 1GQU08-0000MK-69; Thu, 21 Sep 2006 15:14:24 -0400 Date: Thu, 21 Sep 2006 19:14:00 -0000 From: Daniel Jacobowitz To: Michael Snyder Cc: gdb-patches@sourceware.org Subject: Re: [rfa] NEWS additions for flash Message-ID: <20060921191424.GA1283@nevyn.them.org> Mail-Followup-To: Michael Snyder , gdb-patches@sourceware.org References: <20060921141803.GD22556@nevyn.them.org> <1158865857.22863.1.camel@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1158865857.22863.1.camel@localhost.localdomain> User-Agent: Mutt/1.5.13 (2006-08-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-09/txt/msg00131.txt.bz2 On Thu, Sep 21, 2006 at 12:10:56PM -0700, Michael Snyder wrote: > On Thu, 2006-09-21 at 10:18 -0400, Daniel Jacobowitz wrote: > > This patch adds news entries for the flash patches I've just checked > > in. Is this OK? > > > > The next release is shaping up to be quite an improvement. > > On a quick scan of your (today's) patch, I don't see any tests. > Is this testable? In theory, you could write some tests for it using 'gdbreplay'. But getting gdbreplay to work in the testsuite harness would be quite tricky, and it would be complicated by the fact that which registers GDB asks for at connection is target dependent; I don't know how to write generic remote protocol tests. I'd love to unit test this stuff. If you have any suggestions, I'm all ears. -- Daniel Jacobowitz CodeSourcery