Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@false.org>
To: gdb-patches@sourceware.org
Subject: Re: Flash support part 3: documentation
Date: Wed, 20 Sep 2006 22:21:00 -0000	[thread overview]
Message-ID: <20060920222106.GA29384@nevyn.them.org> (raw)
In-Reply-To: <uk665g2fr.fsf@gnu.org>

On Sat, Jul 22, 2006 at 05:05:28PM +0300, Eli Zaretskii wrote:
> > Here's yet another revision of the patch.
> 
> This is approved to go in; thanks.

Hi Eli,

I'll be around to applying these patches shortly, after unanticipated
delay.  I have two small changes to the documentation; does this look
OK (along with Vlad's patch)?  The only changes are a minor grammar
nit, and a clarification for one thing we found particularly confusing
when implementing this spec: that vFlashWrite packets only have an
ordering requirement w.r.t. other vFlashWrite packets, but that GDB's
behavior of sending all the erase packets before any write packets
was intended to be OK.

-- 
Daniel Jacobowitz
CodeSourcery

Index: src/gdb/doc/gdb.texinfo
===================================================================
--- src.orig/gdb/doc/gdb.texinfo	2006-09-20 18:18:50.000000000 -0400
+++ src/gdb/doc/gdb.texinfo	2006-09-20 18:12:14.000000000 -0400
@@ -23181,10 +23181,12 @@ Direct the stub to write data to flash a
 is passed in binary form using the same encoding as for the @samp{X}
 packet (@pxref{Binary Data}).  The memory ranges specified by
 @samp{vFlashWrite} packets preceding a @samp{vFlashDone} packet must
-not overlap, and must appear in order of increasing addresses.  If a
-packet writes to an address that was neither erased by a preceding
-@samp{vFlashErase} packet nor by some other target-specific method,
-the results are unpredictable.
+not overlap, and must appear in order of increasing addresses
+(although @samp{vFlashErase} packets for higher addresses may already
+have been received; the ordering is guaranteed only between
+@samp{vFlashWrite} packets).  If a packet writes to an address that was
+neither erased by a preceding @samp{vFlashErase} packet nor by some other
+target-specific method, the results are unpredictable.
 
 
 Reply:
@@ -25367,7 +25369,7 @@ host is called:
 @section Memory map format
 @cindex memory map format
 
-To be able to write into flash memory, @value{GDBN} needs to obtain
+To be able to write into flash memory, @value{GDBN} needs to obtain a
 memory map from the target.  This section describes the format of the
 memory map.
 


  reply	other threads:[~2006-09-20 22:21 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-07-20  9:43 Vladimir Prus
2006-07-20 19:57 ` Eli Zaretskii
2006-07-21 12:04   ` Vladimir Prus
2006-07-21 15:33     ` Eli Zaretskii
2006-07-22 12:40       ` Vladimir Prus
2006-07-22 14:05         ` Eli Zaretskii
2006-09-20 22:21           ` Daniel Jacobowitz [this message]
2006-09-21  3:22             ` Eli Zaretskii
2006-09-21 14:01               ` Daniel Jacobowitz
2006-08-17  8:24         ` Daniel Jacobowitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060920222106.GA29384@nevyn.them.org \
    --to=drow@false.org \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox