From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24645 invoked by alias); 17 Sep 2006 15:10:55 -0000 Received: (qmail 24637 invoked by uid 22791); 17 Sep 2006 15:10:54 -0000 X-Spam-Check-By: sourceware.org Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Sun, 17 Sep 2006 15:10:53 +0000 Received: from drow by nevyn.them.org with local (Exim 4.54) id 1GOyIF-0005gJ-Fe; Sun, 17 Sep 2006 11:10:51 -0400 Date: Sun, 17 Sep 2006 15:10:00 -0000 From: Daniel Jacobowitz To: Mike Frysinger Cc: gdb-patches@sourceware.org Subject: Re: [patch ping] change lookup order of $localvars to happen before symbol tables Message-ID: <20060917151051.GA21071@nevyn.them.org> Mail-Followup-To: Mike Frysinger , gdb-patches@sourceware.org References: <200608200903.07185.vapier@gentoo.org> <200609140100.54614.vapier@gentoo.org> <20060916040222.GA7673@nevyn.them.org> <200609170022.09732.vapier@gentoo.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200609170022.09732.vapier@gentoo.org> User-Agent: Mutt/1.5.13 (2006-08-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-09/txt/msg00089.txt.bz2 On Sun, Sep 17, 2006 at 12:22:08AM -0400, Mike Frysinger wrote: > > Would you mind resubmitting with those changes? > > sure, ive attached two versions ... the first is just the previous patch with > your requested changes while the second is that plus breaking up the > internal_lookup() function into lookup_only_internal() and > create_internal() ... doesnt matter to me which of these patches are accepted > as they both accomplish my original goal :) Nice. The second one is OK. There's one small problem; I don't think we get to call a patch of this size trivial, and I don't see a copyright assignment for you on file. Am I missing one? If not, I think I have to ask you to put one in place. -- Daniel Jacobowitz CodeSourcery