From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21486 invoked by alias); 16 Sep 2006 04:12:02 -0000 Received: (qmail 21476 invoked by uid 22791); 16 Sep 2006 04:12:02 -0000 X-Spam-Check-By: sourceware.org Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Sat, 16 Sep 2006 04:12:00 +0000 Received: from drow by nevyn.them.org with local (Exim 4.54) id 1GORX4-00026E-96; Sat, 16 Sep 2006 00:11:58 -0400 Date: Sat, 16 Sep 2006 04:12:00 -0000 From: Daniel Jacobowitz To: balrogg@gmail.com Cc: gdb-patches@sources.redhat.com Subject: Re: [PATCH] interpreter-exec error path Message-ID: <20060916041158.GD7673@nevyn.them.org> Mail-Followup-To: balrogg@gmail.com, gdb-patches@sources.redhat.com References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.13 (2006-08-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-09/txt/msg00084.txt.bz2 On Mon, Sep 11, 2006 at 02:48:33AM +0200, andrzej zaborowski wrote: > If any of the commands executed through "interpreter-exec" fails, the > "quiet" value is not restored for the interpreter. This may result in > something like the following. > > (gdb) interpreter-exec console rubbish > Undefined command: "rubbish". Try "help". > error in command: "rubbish". > > readline: readline_callback_read_char() called with no handler! > Aborted Thanks for the patch! Regardless of the bigger picture, I think it's correct for the current code, so I've applied it. -- Daniel Jacobowitz CodeSourcery