From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15324 invoked by alias); 13 Sep 2006 20:09:22 -0000 Received: (qmail 15314 invoked by uid 22791); 13 Sep 2006 20:09:21 -0000 X-Spam-Check-By: sourceware.org Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Wed, 13 Sep 2006 20:09:19 +0000 Received: from drow by nevyn.them.org with local (Exim 4.54) id 1GNb2r-0005N7-MS for gdb-patches@sourceware.org; Wed, 13 Sep 2006 16:09:17 -0400 Date: Wed, 13 Sep 2006 20:09:00 -0000 From: Daniel Jacobowitz To: gdb-patches@sourceware.org Subject: Re: [RFC] h8300 "info registers" fix Message-ID: <20060913200917.GA20574@nevyn.them.org> Mail-Followup-To: gdb-patches@sourceware.org References: <0F4DF2E21F33DD46BE7B8CDEEB0E16D307EAB2@ussunex01.palmsource.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0F4DF2E21F33DD46BE7B8CDEEB0E16D307EAB2@ussunex01.palmsource.com> User-Agent: Mutt/1.5.13 (2006-08-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-09/txt/msg00067.txt.bz2 On Wed, Sep 13, 2006 at 01:00:17PM -0700, Michael Snyder wrote: > > At Wed, 13 Sep 2006 00:04:58 +0900, > Yoshinori Sato wrote: > > I modified it in technique to think that I was appropriate. > > OK, much better. Just one more question. > > Your change to h8300_pseudo_register_read (and write): is it because > someone is calling the function with a one-byte buffer? I assume so, > but who is making that call? I'm not familiar with this target, but are there host endianness problems with this patch? Casting an unsigned long * pointer to a gdb_byte * pointer is very suspicious. -- Daniel Jacobowitz CodeSourcery