Re: [RFA/testsuite] Remove all remaining gdb_suppress_entire_file

Daniel Jacobowitz
2006-08-08T19:00:58Z

On Fri, Jul 21, 2006 at 07:28:42PM -0400, Daniel Jacobowitz wrote:
> On Sat, Jul 22, 2006 at 12:05:54AM +0200, Mark Kettenis wrote:
> > > Date: Thu, 20 Jul 2006 17:26:19 -0700
> > > From: Joel Brobecker <brobecker@adacore.com>
> > >
> > > Hello,
> > >
> > > As discussed in the following message:
> > >
> > > http://www.sourceware.org/ml/gdb-patches/2006-06/msg00347.html
> > >
> > > The attached patch removes all remaining instances of
> > > gdb_suppress_entire_file, and replaces them with a call to untested
> > > followed by a return.
> >
> > Hi Joel,
> >
> > Most of these are checking compile failures. Are we still seeing some
> > sort of ERROR about that in the testsuite output, or just UNTESTED?
>
> gdb_suppress_entire_file used to issue a WARNING. There was never
> supposed to be any ERROR - they were caused by cascading failures,
> DejaGNU getting confused, and usually the first symptom was a fake
> "timeout" while trying to load a file into GDB. And that generated an
> ERROR.
>
> After Joel's patch I believe we'll only get an UNTESTED. If you'd
> rather we could leave the warning?

Hi Mark,

Did you have any opinion on this? One way or another I'd like to get
this patch squared away.