From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14819 invoked by alias); 2 Aug 2006 22:31:00 -0000 Received: (qmail 14801 invoked by uid 22791); 2 Aug 2006 22:30:59 -0000 X-Spam-Check-By: sourceware.org Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Wed, 02 Aug 2006 22:30:56 +0000 Received: from drow by nevyn.them.org with local (Exim 4.54) id 1G8PEp-0000Mb-RD; Wed, 02 Aug 2006 18:30:51 -0400 Date: Wed, 02 Aug 2006 22:31:00 -0000 From: Daniel Jacobowitz To: Mark Kettenis Cc: nathan@codesourcery.com, gdb@sourceware.org, gdb-patches@sourceware.org Subject: Re: Bogus change to gdb.base/cursal.exp? Message-ID: <20060802223051.GA1048@nevyn.them.org> Mail-Followup-To: Mark Kettenis , nathan@codesourcery.com, gdb@sourceware.org, gdb-patches@sourceware.org References: <200608012238.k71McI5N001797@elgar.sibelius.xs4all.nl> <20060801225822.GA26808@nevyn.them.org> <200608022117.k72LH4eR004504@elgar.sibelius.xs4all.nl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200608022117.k72LH4eR004504@elgar.sibelius.xs4all.nl> User-Agent: Mutt/1.5.11+cvs20060403 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-08/txt/msg00028.txt.bz2 On Wed, Aug 02, 2006 at 11:17:04PM +0200, Mark Kettenis wrote: > Sorry guys, but this still doesn't work on a native GDB: > > Running ../../../../src/gdb/gdb/testsuite/gdb.base/cursal.exp ... > ERROR: couldn't load into /home/kettenis/obj/gdb/gdb/testsuite/../../gdb/gdb (timed out). > > So I repeat my request; would you be so kind to back this out until > you've found a solution that doesn't break this test on a native GDB? I'm really sorry about this, Mark. I thought I tested that last one on native GDB too. I spent a little while looking at "fixing" the various load procedures on the assumption that gdb_load "" ought to do something consistent, but it's really not worth it. I've tested and committed this much less complicated fix, which works in every case I could throw at it. -- Daniel Jacobowitz CodeSourcery 2006-08-02 Daniel Jacobowitz * cursal.exp: Pass binfile to gdb_load. Index: gdb.base/cursal.exp =================================================================== RCS file: /cvs/src/src/gdb/testsuite/gdb.base/cursal.exp,v retrieving revision 1.3 diff -u -p -r1.3 cursal.exp --- gdb.base/cursal.exp 1 Aug 2006 22:57:49 -0000 1.3 +++ gdb.base/cursal.exp 2 Aug 2006 22:29:21 -0000 @@ -42,7 +42,8 @@ gdb_test "set listsize 1" \ gdb_test "list" \ "v0 = 0;" \ "list before run" -gdb_load "" + +gdb_load ${binfile} if {! [runto_main]} { return -1 }