From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2469 invoked by alias); 24 Jul 2006 20:18:50 -0000 Received: (qmail 2460 invoked by uid 22791); 24 Jul 2006 20:18:50 -0000 X-Spam-Check-By: sourceware.org Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Mon, 24 Jul 2006 20:18:48 +0000 Received: from drow by nevyn.them.org with local (Exim 4.54) id 1G56t4-0004IL-DT; Mon, 24 Jul 2006 16:18:46 -0400 Date: Mon, 24 Jul 2006 20:18:00 -0000 From: Daniel Jacobowitz To: Bob Wilson Cc: gdb-patches@sources.redhat.com Subject: Re: [PATCH] print newline after copyright message Message-ID: <20060724201846.GC15759@nevyn.them.org> Mail-Followup-To: Bob Wilson , gdb-patches@sources.redhat.com References: <4502EB65-3352-4094-8397-AD0E93913023@tensilica.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4502EB65-3352-4094-8397-AD0E93913023@tensilica.com> User-Agent: Mutt/1.5.11+cvs20060403 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-07/txt/msg00349.txt.bz2 On Wed, Jul 19, 2006 at 01:33:34PM -0700, Bob Wilson wrote: > 2006-07-19 Bob Wilson > > * main.c (captured_main): Print a newline after calling > print_gdb_version instead of waiting until after the symbol > file > has been read. Adjust {error,quit,warning}_pre_print values. > Thanks, I agree with your logic. This patch is OK. Please don't use {A,B} notation in changelogs, though - spell it out. -- Daniel Jacobowitz CodeSourcery