From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27098 invoked by alias); 21 Jul 2006 23:28:54 -0000 Received: (qmail 27084 invoked by uid 22791); 21 Jul 2006 23:28:53 -0000 X-Spam-Check-By: sourceware.org Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Fri, 21 Jul 2006 23:28:48 +0000 Received: from drow by nevyn.them.org with local (Exim 4.54) id 1G44QE-0007pL-Iv; Fri, 21 Jul 2006 19:28:42 -0400 Date: Fri, 21 Jul 2006 23:28:00 -0000 From: Daniel Jacobowitz To: Mark Kettenis Cc: brobecker@adacore.com, gdb-patches@sources.redhat.com Subject: Re: [RFA/testsuite] Remove all remaining gdb_suppress_entire_file Message-ID: <20060721232842.GA30038@nevyn.them.org> Mail-Followup-To: Mark Kettenis , brobecker@adacore.com, gdb-patches@sources.redhat.com References: <20060721002619.GE1499@adacore.com> <200607212205.k6LM5sNC003058@elgar.sibelius.xs4all.nl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200607212205.k6LM5sNC003058@elgar.sibelius.xs4all.nl> User-Agent: Mutt/1.5.11+cvs20060403 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-07/txt/msg00306.txt.bz2 On Sat, Jul 22, 2006 at 12:05:54AM +0200, Mark Kettenis wrote: > > Date: Thu, 20 Jul 2006 17:26:19 -0700 > > From: Joel Brobecker > > > > Hello, > > > > As discussed in the following message: > > > > http://www.sourceware.org/ml/gdb-patches/2006-06/msg00347.html > > > > The attached patch removes all remaining instances of > > gdb_suppress_entire_file, and replaces them with a call to untested > > followed by a return. > > Hi Joel, > > Most of these are checking compile failures. Are we still seeing some > sort of ERROR about that in the testsuite output, or just UNTESTED? gdb_suppress_entire_file used to issue a WARNING. There was never supposed to be any ERROR - they were caused by cascading failures, DejaGNU getting confused, and usually the first symptom was a fake "timeout" while trying to load a file into GDB. And that generated an ERROR. After Joel's patch I believe we'll only get an UNTESTED. If you'd rather we could leave the warning? -- Daniel Jacobowitz CodeSourcery