From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9073 invoked by alias); 18 Jul 2006 20:47:56 -0000 Received: (qmail 9065 invoked by uid 22791); 18 Jul 2006 20:47:56 -0000 X-Spam-Check-By: sourceware.org Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Tue, 18 Jul 2006 20:47:54 +0000 Received: from drow by nevyn.them.org with local (Exim 4.54) id 1G2wTw-0007IU-PZ; Tue, 18 Jul 2006 16:47:52 -0400 Date: Tue, 18 Jul 2006 20:47:00 -0000 From: Daniel Jacobowitz To: Nathan Sidwell Cc: gdb-patches@sourceware.org Subject: Re: fix remote-fileio breakage Message-ID: <20060718204752.GC27666@nevyn.them.org> Mail-Followup-To: Nathan Sidwell , gdb-patches@sourceware.org References: <44BC9088.4070700@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <44BC9088.4070700@codesourcery.com> User-Agent: Mutt/1.5.11+cvs20060403 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-07/txt/msg00246.txt.bz2 On Tue, Jul 18, 2006 at 08:40:56AM +0100, Nathan Sidwell wrote: > It appears that recent changes to remote protocol handling have exposed a > latent bug in remote fileio. Two of the remote fileio calls start reading > target memory before completely processing the fileio response packet. > Reading remote memory overwrites that buffer. Yeah, you're right. > 2006-07-18 Nathan Sidwell > > * remote-fileio.c (remote_fileio_func_rename): Reorder to process > input buffer before reading memory. > (remote_fileio_func_stat): Likewise. OK, thanks. -- Daniel Jacobowitz CodeSourcery