From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 868 invoked by alias); 18 Jul 2006 12:48:56 -0000 Received: (qmail 859 invoked by uid 22791); 18 Jul 2006 12:48:54 -0000 X-Spam-Check-By: sourceware.org Received: from potter.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 18 Jul 2006 12:48:52 +0000 Received: (qmail 20412 invoked from network); 18 Jul 2006 12:48:50 -0000 Received: from unknown (HELO zigzag.lvk.cs.msu.su) (vladimir@127.0.0.2) by mail.codesourcery.com with ESMTPA; 18 Jul 2006 12:48:50 -0000 From: Vladimir Prus To: gdb-patches@sources.redhat.com Subject: [PATCH] remove download_write_size variable Date: Tue, 18 Jul 2006 12:48:00 -0000 User-Agent: KMail/1.7.2 MIME-Version: 1.0 Content-Type: Multipart/Mixed; boundary="Boundary-00=_tiNvEzsNYYsvBHL" Message-Id: <200607181648.45180.vladimir@codesourcery.com> Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-07/txt/msg00228.txt.bz2 --Boundary-00=_tiNvEzsNYYsvBHL Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Content-Disposition: inline Content-length: 690 This patch removes the 'download_write_size'. At the moment, is has pretty low value, it's not clear why we need a separate option for just one command, and the new qSupported packet allows to negotiate packet size with the stub. So, I don't see any reason why this variable is needed, and given that flash patches will seriously change symfile.c anyway, I suggest that we "garbage-collect" this variable. Comments? - Volodya 2006-07-18 Vladimir Prus * symfile.c (download_write_size): Remove. (show_download_write_size): Remove. (load_section_callback): Don't use download_write_size. (_initialize_symfile): Don't register download_write_size. --Boundary-00=_tiNvEzsNYYsvBHL Content-Type: text/x-diff; charset="us-ascii"; name="4_download_write_size.diff" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="4_download_write_size.diff" Content-length: 2193 --- symfile.c (revision 176) +++ symfile.c (revision 177) @@ -1521,15 +1521,6 @@ load_command (char *arg, int from_tty) we don't want to run a subprocess. On the other hand, I'm not sure how performance compares. */ -static int download_write_size = 512; -static void -show_download_write_size (struct ui_file *file, int from_tty, - struct cmd_list_element *c, const char *value) -{ - fprintf_filtered (file, _("\ -The write size used when downloading a program is %s.\n"), - value); -} static int validate_download = 0; /* Callback service function for generic_load (bfd_map_over_sections). */ @@ -1570,11 +1561,6 @@ load_section_callback (bfd *abfd, asecti const char *sect_name = bfd_get_section_name (abfd, asec); bfd_size_type sent; - if (download_write_size > 0 && size > download_write_size) - block_size = download_write_size; - else - block_size = size; - buffer = xmalloc (size); old_chain = make_cleanup (xfree, buffer); @@ -1591,8 +1577,6 @@ load_section_callback (bfd *abfd, asecti int len; bfd_size_type this_transfer = size - sent; - if (this_transfer >= block_size) - this_transfer = block_size; len = target_write_memory_partial (lma, buffer, this_transfer, &err); if (err) @@ -3806,19 +3790,6 @@ Usage: set extension-language .foo bar") add_info ("extensions", info_ext_lang_command, _("All filename extensions associated with a source language.")); - add_setshow_integer_cmd ("download-write-size", class_obscure, - &download_write_size, _("\ -Set the write size used when downloading a program."), _("\ -Show the write size used when downloading a program."), _("\ -Only used when downloading a program onto a remote\n\ -target. Specify zero, or a negative value, to disable\n\ -blocked writes. The actual size of each transfer is also\n\ -limited by the size of the target packet and the memory\n\ -cache."), - NULL, - show_download_write_size, - &setlist, &showlist); - debug_file_directory = xstrdup (DEBUGDIR); add_setshow_optional_filename_cmd ("debug-file-directory", class_support, &debug_file_directory, _("\ --Boundary-00=_tiNvEzsNYYsvBHL--