From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19973 invoked by alias); 16 Jul 2006 11:42:39 -0000 Received: (qmail 19963 invoked by uid 22791); 16 Jul 2006 11:42:39 -0000 X-Spam-Check-By: sourceware.org Received: from sibelius.xs4all.nl (HELO sibelius.xs4all.nl) (82.92.89.47) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sun, 16 Jul 2006 11:42:35 +0000 Received: from elgar.sibelius.xs4all.nl (root@elgar.sibelius.xs4all.nl [192.168.0.2]) by sibelius.xs4all.nl (8.13.4/8.13.4) with ESMTP id k6GBgQ9R031134; Sun, 16 Jul 2006 13:42:26 +0200 (CEST) Received: from elgar.sibelius.xs4all.nl (kettenis@localhost.sibelius.xs4all.nl [127.0.0.1]) by elgar.sibelius.xs4all.nl (8.13.6/8.13.6) with ESMTP id k6GBgQsq018954; Sun, 16 Jul 2006 13:42:26 +0200 (CEST) Received: (from kettenis@localhost) by elgar.sibelius.xs4all.nl (8.13.6/8.13.6/Submit) id k6GBgPGf020488; Sun, 16 Jul 2006 13:42:25 +0200 (CEST) Date: Sun, 16 Jul 2006 11:42:00 -0000 Message-Id: <200607161142.k6GBgPGf020488@elgar.sibelius.xs4all.nl> From: Mark Kettenis To: Nick Roberts CC: gdb-patches@sourceware.org Subject: Testsuite failures Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-07/txt/msg00180.txt.bz2 Hi Nick, I'm seeing some new testsuite failures on several OpenBSD machines: Running ../../../../src/gdb/gdb/testsuite/gdb.base/annota3.exp ... FAIL: gdb.base/annota3.exp: run until main breakpoint (pattern 6) FAIL: gdb.base/annota3.exp: send SIGUSR1 (pattern 5) FAIL: gdb.base/annota3.exp: annotate ignore count change (pattern 3) I think these are caused by your last commit: 2006-07-13 Nick Roberts * annotate.c (annotate_frame_begin): Re-instate frame-begin annotation for level 3 annotations. Here's a patch that adjusts the testsuite to deal with the re-instated frame-begin annotation. Can you verify that this is indeed the intended effect of your change? Index: ChangeLog from Mark Kettenis * gdb.base/annota3.exp: Adjust patterns for re-instated frame-begin annotation. Index: gdb.base/annota3.exp =================================================================== RCS file: /cvs/src/src/gdb/testsuite/gdb.base/annota3.exp,v retrieving revision 1.7 diff -u -p -r1.7 annota3.exp --- gdb.base/annota3.exp 7 Mar 2006 15:23:32 -0000 1.7 +++ gdb.base/annota3.exp 16 Jul 2006 11:41:02 -0000 @@ -112,6 +112,7 @@ gdb_expect_list "breakpoint info" "$gdb_ # # run to a break point will test: +# annotate-frame-begin # #exp_internal 1 send_gdb "run\n" @@ -121,7 +122,9 @@ gdb_expect_list "run until main breakpoi "\r\n\032\032starting\r\n" "\r\n\032\032breakpoint 1\r\n" "\r\n" - "Breakpoint 1, main \\(\\) at .*annota3.c:32\r\n" + "Breakpoint 1, " + "\r\n\032\032frame-begin 0 0x\[0-9a-z\]+\r\n" + "main \\(\\) at .*annota3.c:32\r\n" "\r\n\032\032source.*annota3.c:32:.*:beg:0x\[0-9a-z\]+\r\n" "\r\n\032\032stopped\r\n" } @@ -222,7 +225,10 @@ if [target_info exists gdb,nosignals] { "Continuing with signal SIGUSR1.\r\n" "\r\n\032\032starting\r\n" "\r\n\032\032breakpoint 2\r\n" - "Breakpoint 2, handle_USR1 \\(sig=\[0-9\]+\\) at .*annota3.c:\[0-9\]+\r\n" + "\r\n" + "Breakpoint 2, " + "\r\n\032\032frame-begin 0 0x\[0-9a-z\]+\r\n" + "handle_USR1 \\(sig=\[0-9\]+\\) at .*annota3.c:\[0-9\]+\r\n" "\r\n\032\032source .*annota3.c:\[0-9\]+:\[0-9\]+:beg:0x\[0-9a-z\]+\r\n" "\r\n\032\032stopped\r\n" } @@ -324,7 +330,10 @@ send_gdb "continue\n" gdb_expect_list "annotate ignore count change" "$gdb_prompt$" { "\r\n\032\032post-prompt\r\n" "\r\n\032\032breakpoint 5\r\n" - "Breakpoint 5, main \\(\\) at .*annota3.c:46\r\n" + "\r\n" + "Breakpoint 5, " + "\r\n\032\032frame-begin 0 0x\[0-9a-z\]+\r\n" + "main \\(\\) at .*annota3.c:46\r\n" "\r\n\032\032source .*annota3.c:46:\[0-9\]+:beg:0x\[0-9a-z\]+\r\n" "1: value = 11\r\n" "\r\n\032\032stopped\r\n"