Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@false.org>
To: Mark Kettenis <mark.kettenis@xs4all.nl>
Cc: lace@jankratochvil.net, gdb-patches@sourceware.org,
		bartoschek@or.uni-bonn.de
Subject: Re: RFC: Re: [patch] Fix for 'info threads' crashes if zombie threads exist
Date: Thu, 13 Jul 2006 19:47:00 -0000	[thread overview]
Message-ID: <20060713194731.GA1709@nevyn.them.org> (raw)
In-Reply-To: <200607131849.k6DInqeJ029991@elgar.sibelius.xs4all.nl>

On Thu, Jul 13, 2006 at 08:49:52PM +0200, Mark Kettenis wrote:
> Probably a good idea, given the fact that it's unlikely we'll see a
> N:M threads library on Linux is the near future.

Exactly.  I've already removed functional M:N support in the interest
of improving the 1:1 support we're actually using; these are some of
the remaining vestigal bits.

> > It also (long overdue) removes the dependence on fill_gregset, and
> > removes a not especially useful call into libthread_db for converting
> > threads to strings.  There are a number of more possible cleanups,
> > but this hits the big ones.
> 
> Doesn't your simplification of thread_db_pid_to_str() lose some useful
> information about the extra system thread that the LinuxThreads
> library used to have (I'm not sure if that wart is still present in
> NPTL)?

It's not still present in NPTL.

It doesn't actually lose anything about the manager thread, because we
were never providing any in the first place.  We were only checking the
thread state, and the manager would always be TD_THR_ACTIVE.  That was
really only useful on platforms which did use the other states, like
STOPPED and SLEEP, but LinuxThreads didn't.

Such information might have been handy - but we don't have any reliable
way to identify the manager thread :-(

> You might want to look at implementing to_extra_thread_info() to give
> some state information; see bsd-uthread.c for an example.

... and in any case that's a better place for the state information.
Nice.  Unfortunately we don't really have useful state bits.  I could
probably move the exiting/missing text there.  I'll keep that in mind
for a future update, thanks!

-- 
Daniel Jacobowitz
CodeSourcery


  reply	other threads:[~2006-07-13 19:47 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <200606191719.00530.bartoschek@or.uni-bonn.de>
     [not found] ` <200606201542.12070.bartoschek@or.uni-bonn.de>
     [not found]   ` <20060620135351.GA9853@host0.dyn.jankratochvil.net>
     [not found]     ` <200606201821.41941.bartoschek@or.uni-bonn.de>
     [not found]       ` <200606201456.57681.bartoschek@or.uni-bonn.de>
     [not found]         ` <20060620130932.GA21490@nevyn.them.org>
     [not found]           ` <200606201524.45099.bartoschek@or.uni-bonn.de>
     [not found]             ` <20060620132737.GA21951@nevyn.them.org>
2006-06-19 16:56               ` Jan Kratochvil
2006-06-20 17:05                 ` RFC: " Jan Kratochvil
2006-06-20 17:11                   ` Daniel Jacobowitz
2006-06-20 18:54                     ` Jan Kratochvil
2006-06-20 19:07                       ` Daniel Jacobowitz
2006-07-13  4:01                         ` Daniel Jacobowitz
2006-07-13 13:28                           ` Jan Kratochvil
2006-07-13 13:43                             ` Daniel Jacobowitz
2006-07-13 15:07                               ` Jan Kratochvil
2006-07-13 18:50                           ` Mark Kettenis
2006-07-13 19:47                             ` Daniel Jacobowitz [this message]
2006-07-13 23:16                               ` Mark Kettenis
2006-07-18 22:55                                 ` Daniel Jacobowitz
2006-07-14 13:15                           ` Christoph Bartoschek
2006-07-14 13:36                             ` Daniel Jacobowitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060713194731.GA1709@nevyn.them.org \
    --to=drow@false.org \
    --cc=bartoschek@or.uni-bonn.de \
    --cc=gdb-patches@sourceware.org \
    --cc=lace@jankratochvil.net \
    --cc=mark.kettenis@xs4all.nl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox