From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8375 invoked by alias); 11 Jul 2006 22:59:38 -0000 Received: (qmail 8367 invoked by uid 22791); 11 Jul 2006 22:59:38 -0000 X-Spam-Check-By: sourceware.org Received: from sibelius.xs4all.nl (HELO sibelius.xs4all.nl) (82.92.89.47) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 11 Jul 2006 22:59:36 +0000 Received: from elgar.sibelius.xs4all.nl (root@elgar.sibelius.xs4all.nl [192.168.0.2]) by sibelius.xs4all.nl (8.13.4/8.13.4) with ESMTP id k6BMxW76027917; Wed, 12 Jul 2006 00:59:32 +0200 (CEST) Received: from elgar.sibelius.xs4all.nl (kettenis@localhost.sibelius.xs4all.nl [127.0.0.1]) by elgar.sibelius.xs4all.nl (8.13.6/8.13.6) with ESMTP id k6BMxWgY031115; Wed, 12 Jul 2006 00:59:32 +0200 (CEST) Received: (from kettenis@localhost) by elgar.sibelius.xs4all.nl (8.13.6/8.13.6/Submit) id k6BMxWae016835; Wed, 12 Jul 2006 00:59:32 +0200 (CEST) Date: Tue, 11 Jul 2006 22:59:00 -0000 Message-Id: <200607112259.k6BMxWae016835@elgar.sibelius.xs4all.nl> From: Mark Kettenis To: pecarr@linux.ibm.com CC: gdb-patches@sources.redhat.com In-reply-to: <44B42374.1000109@linux.ibm.com> (message from Pete Carr on Tue, 11 Jul 2006 15:17:24 -0700) Subject: Re: [PATCH] Bug 23438. Support for 128-bit long double types on PowerPC 64] References: <44B42374.1000109@linux.ibm.com> Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-07/txt/msg00103.txt.bz2 > Date: Tue, 11 Jul 2006 15:17:24 -0700 > From: Pete Carr > > Hi, Hi Pete, Welcome to GDB. > Please note that there are changes to floatformat.h and floatformat.c which > are held under include and libiberty subdirectories. Those bits need to be handled seperately; see the toplevel MAINTAINERS file for details. > This is my first patch submission so I'd appreciate guidance if I have > not followed the rules. You'll need to work a bit on your coding style ;-). I noticed that your lines tend to be too long (there's some debate what the maximum length is, but they definitely should be under 79 characters), and you comments are no formatted correctly. Please take some time to read the GNU coding standards; feel free to ask any questions that remain after doing that. As for the patch, the change to rs6000-tdep.c is almost certainly wrong, since it also seems to affect 32-bit powerpc and POWER stuff. Regarding the ppc-linux-tdep.c change: we generally don't #ifdef out code, but just remove it, since CVS tracks the history for us. But again, I don't think this change is right, since the code is also for 32-bit powerpc support. And even for powerpc64, there still are systems out there that use the old ABI with 64-bit long doubles isn't it? How does this change affect those systems? Mark