From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5515 invoked by alias); 11 Jul 2006 22:48:10 -0000 Received: (qmail 5506 invoked by uid 22791); 11 Jul 2006 22:48:10 -0000 X-Spam-Check-By: sourceware.org Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Tue, 11 Jul 2006 22:48:08 +0000 Received: from drow by nevyn.them.org with local (Exim 4.54) id 1G0R1S-0000Rr-Mm; Tue, 11 Jul 2006 18:48:06 -0400 Date: Tue, 11 Jul 2006 22:48:00 -0000 From: Daniel Jacobowitz To: Mark Kettenis Cc: gdb-patches@sourceware.org Subject: Re: [rft/symtab] Check the sizes of minimal symbols Message-ID: <20060711224806.GA1686@nevyn.them.org> Mail-Followup-To: Mark Kettenis , gdb-patches@sourceware.org References: <20060707035420.GA8071@nevyn.them.org> <200607092026.k69KQKQg027664@elgar.sibelius.xs4all.nl> <20060709203557.GA21606@nevyn.them.org> <200607112200.k6BM0nQT004757@elgar.sibelius.xs4all.nl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200607112200.k6BM0nQT004757@elgar.sibelius.xs4all.nl> User-Agent: Mutt/1.5.11+cvs20060403 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-07/txt/msg00101.txt.bz2 On Wed, Jul 12, 2006 at 12:00:49AM +0200, Mark Kettenis wrote: > > Date: Sun, 9 Jul 2006 16:35:57 -0400 > > From: Daniel Jacobowitz > > > > > Program received signal SIGSEGV, Segmentation fault. > > > 0x1c0066a8 in lookup_minimal_symbol_by_pc_section (pc=469800299, > > > section=0x800e95fc) at ../../../src/gdb/gdb/minsyms.c:535 > > > 535 if (MSYMBOL_SIZE (&msymbol[hi]) != 0 > > > > I'm just guessing here but... is hi == -1 when that happens? Does > > adding "hi >= 0 &&" to the front of that if statement help? > > Yes it does. No regressions on OpenBSD/i386. I'll try some of the > other architectures as well later this week. Any in particular that > you'd like to see tested? Nothing jumps out at me; the things that seem likely to be a problem are e.g. hppa/ia64/ppc64. -- Daniel Jacobowitz CodeSourcery