From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16552 invoked by alias); 10 Jul 2006 21:51:21 -0000 Received: (qmail 16535 invoked by uid 22791); 10 Jul 2006 21:51:20 -0000 X-Spam-Check-By: sourceware.org Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Mon, 10 Jul 2006 21:51:18 +0000 Received: from drow by nevyn.them.org with local (Exim 4.54) id 1G03es-0008CS-DL; Mon, 10 Jul 2006 17:51:14 -0400 Date: Mon, 10 Jul 2006 21:51:00 -0000 From: Daniel Jacobowitz To: Joel Brobecker Cc: Eli Zaretskii , gdb-patches@sources.redhat.com Subject: Re: [RFA] New substitute-path commands Message-ID: <20060710215114.GA31444@nevyn.them.org> Mail-Followup-To: Joel Brobecker , Eli Zaretskii , gdb-patches@sources.redhat.com References: <20060706044733.GC673@adacore.com> <1152198199.6282.63.camel@dufur.beaverton.ibm.com> <20060706162952.GB24631@nevyn.them.org> <20060707052219.GA971@adacore.com> <20060707191203.GD971@adacore.com> <20060710054027.GF971@adacore.com> <20060710214706.GA2390@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20060710214706.GA2390@adacore.com> User-Agent: Mutt/1.5.11+cvs20060403 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-07/txt/msg00084.txt.bz2 On Mon, Jul 10, 2006 at 02:47:06PM -0700, Joel Brobecker wrote: > > This version is okay to go in, provided that you fix these small > > gotchas: > > Great! I made the adjustments you suggested, thanks! > > Just to be safe, you have approved both documentation and code, > right? I assume this because you also made some comments about > the code, and some of them were technical. I'll commit as soon > as this is confirmed. FWIW, this version of the interface is fine with me (I didn't look at the code). I strongly agree with Andrew that we should support more than one substitution rule, but we can do that separately. -- Daniel Jacobowitz CodeSourcery