From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32203 invoked by alias); 6 Jul 2006 02:57:18 -0000 Received: (qmail 32193 invoked by uid 22791); 6 Jul 2006 02:57:18 -0000 X-Spam-Check-By: sourceware.org Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Thu, 06 Jul 2006 02:57:16 +0000 Received: from drow by nevyn.them.org with local (Exim 4.54) id 1FyK3E-0001MN-J8; Wed, 05 Jul 2006 22:57:12 -0400 Date: Thu, 06 Jul 2006 02:57:00 -0000 From: Daniel Jacobowitz To: PAUL GILLIAM Cc: Mark Kettenis , gdb-patches@sources.redhat.com Subject: Re: [patch] Fixes problem setting breakpoint in dynamic loader Message-ID: <20060706025712.GA5144@nevyn.them.org> Mail-Followup-To: PAUL GILLIAM , Mark Kettenis , gdb-patches@sources.redhat.com References: <1148513171.315.104.camel@dufur.beaverton.ibm.com> <200606172021.k5HKL82O013629@elgar.sibelius.xs4all.nl> <1152143843.6282.49.camel@dufur.beaverton.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1152143843.6282.49.camel@dufur.beaverton.ibm.com> User-Agent: Mutt/1.5.11+cvs20060403 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-07/txt/msg00020.txt.bz2 Formatting notes. On Wed, Jul 05, 2006 at 04:57:23PM -0700, PAUL GILLIAM wrote: > + contain executable code and we can set a breakpoint there. */ Two spaces after period, here and elsewhere. > + /* No symbol was found in a code section, so look elsewhere. */ > + for (bkpt_namep = solib_break_names; *bkpt_namep!=NULL; bkpt_namep++) Line is too long; also related, spaces around operators. > + /* On ABI's that use function descriptors that are in the data > + section, */ Lost a bit of this comment? -- Daniel Jacobowitz CodeSourcery