From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16811 invoked by alias); 29 Jun 2006 02:34:09 -0000 Received: (qmail 16800 invoked by uid 22791); 29 Jun 2006 02:34:09 -0000 X-Spam-Check-By: sourceware.org Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Thu, 29 Jun 2006 02:34:07 +0000 Received: from drow by nevyn.them.org with local (Exim 4.54) id 1FvmM1-0008Tq-TC for gdb-patches@sourceware.org; Wed, 28 Jun 2006 22:34:05 -0400 Date: Thu, 29 Jun 2006 02:34:00 -0000 From: Daniel Jacobowitz To: gdb-patches@sourceware.org Subject: Re: [PATCH] m32c-tdep.c: Add virtual_frame_pointer function Message-ID: <20060629023405.GA32465@nevyn.them.org> Mail-Followup-To: gdb-patches@sourceware.org References: <20060628132918.GD24606@calimero.vinschen.de> <200606282129.k5SLTfc8004816@elgar.sibelius.xs4all.nl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200606282129.k5SLTfc8004816@elgar.sibelius.xs4all.nl> User-Agent: Mutt/1.5.11+cvs20060403 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-06/txt/msg00396.txt.bz2 On Wed, Jun 28, 2006 at 11:29:41PM +0200, Mark Kettenis wrote: > > Date: Wed, 28 Jun 2006 15:29:18 +0200 > > From: Corinna Vinschen > > > > Hi, > > > > the below patch adds a virtual_frame_pointer function to m32c-tdep.c, > > to avoid that legacy_virtual_frame_pointer is called from tracepoint.c, > > function encode_actions(). The legacy function either expects a > > DEPRECATED_FP_REGNUM function, or it expects SP_REGNUM <= NUM_REGS, > > which is not the case for the m32c code which includes serious > > register banking. The patch avoids all GDB internal errors in the > > gdb.trace testsuite and allows to return PASSes for all these testcases, > > except a single one (FAIL: gdb.trace/packetlen.exp: setup collect actions). > > > > Ok to apply? > > You probably should change legacy_virtual_frame_pointer to check for > SP_REGNUM < NUM_REGS + NUM_PSEUDO_REGS instead. Neither, I don't think! Did this just turn up in a testsuite run, or did you actually try it with tracepoints, Corinna? The assertion seems correct to me. The frame register number is going to get sent to the remote target system. We shouldn't ever do that for pseudo registers, because the target probably doesn't know how to generate their contents... otherwise they'd be real registers. -- Daniel Jacobowitz CodeSourcery