From: Daniel Jacobowitz <drow@false.org>
To: gdb-patches@sourceware.org
Subject: Re: [PATCH] m32c-tdep.c: Don't choke on virtual functions in push_dummy_call
Date: Wed, 28 Jun 2006 21:32:00 -0000 [thread overview]
Message-ID: <20060628213255.GA24718@nevyn.them.org> (raw)
In-Reply-To: <20060628141839.GA29012@calimero.vinschen.de>
On Wed, Jun 28, 2006 at 04:18:39PM +0200, Corinna Vinschen wrote:
> Hi,
>
> the below patch fixes a couple of GDB internal errors when calling
> virtual C++ methods. Virtual methods are not represented as type
> TYPE_CODE_METHOD, but as TYPE_CODE_PTR pointing to TYPE_CODE_METHOD.
> The m32c_push_dummy_call function only checks the function type for
> TYPE_CODE_FUNC or TYPE_CODE_METHOD, which results in a failed assertion
> in case of virtual methods. The below patch skips TYPE_CODE_PTR types
> until it points to the actual TYPE_CODE_METHOD to evaluate further
> necessary data.
>
> Ok to apply?
In addition to Mark's question, which I am also curious about - did
anything in the testsuite catch this, or if not, how can we reproduce
it? - I am currently (i.e. right this moment) rewriting lots of this
stuff. You may wish to wait a little while - though be sure to poke me
about it if I don't have something to check in soon! It is all broken
anyway; GDB is not going to succeed at calling a virtual pointer, it's
going to go off into neverland.
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2006-06-28 21:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-28 14:18 Corinna Vinschen
2006-06-28 21:23 ` Mark Kettenis
2006-06-28 21:32 ` Daniel Jacobowitz [this message]
2006-06-29 11:01 ` Corinna Vinschen
2006-06-29 13:22 ` Daniel Jacobowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060628213255.GA24718@nevyn.them.org \
--to=drow@false.org \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox