Re: [PATCH] m32c-tdep.c: Add virtual_frame_pointer function

Mark Kettenis
2006-06-28T21:29:49Z

> Date: Wed, 28 Jun 2006 15:29:18 +0200
> From: Corinna Vinschen <vinschen@redhat.com>
>
> Hi,
>
> the below patch adds a virtual_frame_pointer function to m32c-tdep.c,
> to avoid that legacy_virtual_frame_pointer is called from tracepoint.c,
> function encode_actions(). The legacy function either expects a
> DEPRECATED_FP_REGNUM function, or it expects SP_REGNUM <= NUM_REGS,
> which is not the case for the m32c code which includes serious
> register banking. The patch avoids all GDB internal errors in the
> gdb.trace testsuite and allows to return PASSes for all these testcases,
> except a single one (FAIL: gdb.trace/packetlen.exp: setup collect actions).
>
> Ok to apply?

You probably should change legacy_virtual_frame_pointer to check for
SP_REGNUM < NUM_REGS + NUM_PSEUDO_REGS instead.