From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-44755-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 14192 invoked by alias); 28 Jun 2006 21:29:49 -0000
Received: (qmail 14184 invoked by uid 22791); 28 Jun 2006 21:29:49 -0000
X-Spam-Check-By: sourceware.org
Received: from sibelius.xs4all.nl (HELO sibelius.xs4all.nl) (82.92.89.47)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 28 Jun 2006 21:29:47 +0000
Received: from elgar.sibelius.xs4all.nl (root@elgar.sibelius.xs4all.nl [192.168.0.2]) 	by sibelius.xs4all.nl (8.13.4/8.13.4) with ESMTP id k5SLTiMh025455 	for <gdb-patches@sourceware.org>; Wed, 28 Jun 2006 23:29:44 +0200 (CEST)
Received: from elgar.sibelius.xs4all.nl (kettenis@localhost.sibelius.xs4all.nl [127.0.0.1]) 	by elgar.sibelius.xs4all.nl (8.13.6/8.13.6) with ESMTP id k5SLTf29013631 	for <gdb-patches@sourceware.org>; Wed, 28 Jun 2006 23:29:41 +0200 (CEST)
Received: (from kettenis@localhost) 	by elgar.sibelius.xs4all.nl (8.13.6/8.13.6/Submit) id k5SLTfc8004816; 	Wed, 28 Jun 2006 23:29:41 +0200 (CEST)
Date: Wed, 28 Jun 2006 21:29:00 -0000
Message-Id: <200606282129.k5SLTfc8004816@elgar.sibelius.xs4all.nl>
From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: gdb-patches@sourceware.org
In-reply-to: <20060628132918.GD24606@calimero.vinschen.de> (message from 	Corinna Vinschen on Wed, 28 Jun 2006 15:29:18 +0200)
Subject: Re: [PATCH] m32c-tdep.c: Add virtual_frame_pointer function
References:  <20060628132918.GD24606@calimero.vinschen.de>
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2006-06/txt/msg00392.txt.bz2

> Date: Wed, 28 Jun 2006 15:29:18 +0200
> From: Corinna Vinschen <vinschen@redhat.com>
> 
> Hi,
> 
> the below patch adds a virtual_frame_pointer function to m32c-tdep.c,
> to avoid that legacy_virtual_frame_pointer is called from tracepoint.c,
> function encode_actions().  The legacy function either expects a 
> DEPRECATED_FP_REGNUM function, or it expects SP_REGNUM <= NUM_REGS,
> which is not the case for the m32c code which includes serious
> register banking.  The patch avoids all GDB internal errors in the
> gdb.trace testsuite and allows to return PASSes for all these testcases,
> except a single one (FAIL: gdb.trace/packetlen.exp: setup collect actions).
> 
> Ok to apply?

You probably should change legacy_virtual_frame_pointer to check for
SP_REGNUM < NUM_REGS + NUM_PSEUDO_REGS instead.