Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@false.org>
To: gdb-patches@sourceware.org
Subject: Re: [rfc] Correct semantics of target_read_partial, add target_read_whole
Date: Wed, 28 Jun 2006 13:49:00 -0000	[thread overview]
Message-ID: <20060628134900.GA12133@nevyn.them.org> (raw)
In-Reply-To: <e7tdvr$q2b$1@sea.gmane.org>

On Wed, Jun 28, 2006 at 12:18:02PM +0400, Vladimir Prus wrote:
> Is there any reason why 'target_read_whole' calls 'target_read', as opposed
> to calling 'target_read_partial' directly? I mean, if target_read_whole can
> do several reads itself, there's no point to use 'target_read'.

Thank you!  Indeed we shouldn't use target_read; it will issue
gratuitous extra packets (by breaking the transfer in the wrong place).

Obviously I need to proofread all these changes again when I get home.

-- 
Daniel Jacobowitz
CodeSourcery


  reply	other threads:[~2006-06-28 13:49 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-06-22  3:24 Daniel Jacobowitz
2006-06-22 18:25 ` Mark Kettenis
2006-06-22 18:37   ` Daniel Jacobowitz
2006-06-29  9:35     ` Vladimir Prus
2006-06-24 10:06 ` Vladimir Prus
2006-06-26 13:38   ` Daniel Jacobowitz
2006-06-28  8:18 ` Vladimir Prus
2006-06-28 13:49   ` Daniel Jacobowitz [this message]
2006-07-05 19:06 ` Daniel Jacobowitz
2006-07-05 19:34   ` Mark Kettenis
2006-07-12 18:15     ` Daniel Jacobowitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060628134900.GA12133@nevyn.them.org \
    --to=drow@false.org \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox