From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6257 invoked by alias); 27 Jun 2006 01:01:02 -0000 Received: (qmail 6242 invoked by uid 22791); 27 Jun 2006 01:01:01 -0000 X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 27 Jun 2006 01:00:59 +0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.11.20060308/8.12.11) with ESMTP id k5R10vTw004249 for ; Mon, 26 Jun 2006 21:00:57 -0400 Received: from pobox.corp.redhat.com (pobox.corp.redhat.com [172.16.52.156]) by int-mx1.corp.redhat.com (8.12.11.20060308/8.12.11) with ESMTP id k5R10qfQ028293 for ; Mon, 26 Jun 2006 21:00:52 -0400 Received: from localhost.localdomain (vpn50-22.rdu.redhat.com [172.16.50.22]) by pobox.corp.redhat.com (8.12.8/8.12.8) with ESMTP id k5R10qLx026447 for ; Mon, 26 Jun 2006 21:00:52 -0400 Received: from ironwood.lan (ironwood.lan [192.168.64.8]) by localhost.localdomain (8.12.11/8.12.10) with ESMTP id k5R10pac016623 for ; Mon, 26 Jun 2006 18:00:52 -0700 Date: Tue, 27 Jun 2006 01:01:00 -0000 From: Kevin Buettner To: gdb-patches@sources.redhat.com Subject: Re: [patch] Fixed occasional failure to load a custom shared library Message-ID: <20060626180051.0adcce23@ironwood.lan> In-Reply-To: <20060622114016.GA21094@host0.dyn.jankratochvil.net> References: <20060622114016.GA21094@host0.dyn.jankratochvil.net> X-Mailer: Sylpheed-Claws 2.0.0 (GTK+ 2.6.10; i386-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-06/txt/msg00383.txt.bz2 On Thu, 22 Jun 2006 13:40:16 +0200 Jan Kratochvil wrote: Index: solib.c =================================================================== RCS file: /cvs/src/src/gdb/solib.c,v retrieving revision 1.84 diff -u -p -r1.84 solib.c --- solib.c 25 Feb 2006 04:36:39 -0000 1.84 +++ solib.c 22 Jun 2006 11:24:40 -0000 @@ -146,13 +146,17 @@ solib_open (char *in_pathname, char **fo int found_file = -1; char *temp_pathname = NULL; char *p = in_pathname; + int solib_absolute_prefix_is_empty; + + solib_absolute_prefix_is_empty = (!solib_absolute_prefix + || !*solib_absolute_prefix); I'd prefer to see this written as follows: + solib_absolute_prefix_is_empty = (solib_absolute_prefix == NULL + || *solib_absolute_prefix == 0); The rest of your patch looks reasonable. (You forgot to include a ChangeLog entry though...) Are you able to commit this yourself or do you need someone to commit it for you? Thanks for the patch! Kevin