From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10468 invoked by alias); 23 Jun 2006 03:22:22 -0000 Received: (qmail 10459 invoked by uid 22791); 23 Jun 2006 03:22:22 -0000 X-Spam-Check-By: sourceware.org Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Fri, 23 Jun 2006 03:22:20 +0000 Received: from drow by nevyn.them.org with local (Exim 4.54) id 1FtcFL-0000ii-78 for gdb-patches@sourceware.org; Thu, 22 Jun 2006 23:22:15 -0400 Date: Fri, 23 Jun 2006 03:22:00 -0000 From: Daniel Jacobowitz To: gdb-patches@sourceware.org Subject: Re: [ob] Eliminate another gdb_suppress_entire_file Message-ID: <20060623032215.GA2754@nevyn.them.org> Mail-Followup-To: gdb-patches@sourceware.org References: <20060622195839.GA20890@nevyn.them.org> <20060623031029.GI976@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20060623031029.GI976@adacore.com> User-Agent: Mutt/1.5.11+cvs20060403 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-06/txt/msg00348.txt.bz2 On Thu, Jun 22, 2006 at 08:10:29PM -0700, Joel Brobecker wrote: > > There's a few versions of GCC 4.1 which can't compile gdb.base/store.c. It > > was eventually fixed on the release branch, but I happen to be testing a > > version where it's broken. I've been making this change globally as the > > function in question pops up to bite me. > > Should we try to remove all the instances of gdb_suppress_entire_file? > I don't remember if there are some cases where it's legit to use them. I'd be in favor. It's not a bad idea, really. But the way the GDB testsuite is layed out, I think it's impractical - and I know that in practice it doesn't work, because it will always provoke an ERROR: Gdb did not load after 10 seconds (or something similar to that). -- Daniel Jacobowitz CodeSourcery