From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30471 invoked by alias); 22 Jun 2006 18:13:34 -0000 Received: (qmail 30381 invoked by uid 22791); 22 Jun 2006 18:13:32 -0000 X-Spam-Check-By: sourceware.org Received: from sibelius.xs4all.nl (HELO sibelius.xs4all.nl) (82.92.89.47) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 22 Jun 2006 18:13:27 +0000 Received: from elgar.sibelius.xs4all.nl (root@elgar.sibelius.xs4all.nl [192.168.0.2]) by sibelius.xs4all.nl (8.13.4/8.13.4) with ESMTP id k5MICppA006269; Thu, 22 Jun 2006 20:12:51 +0200 (CEST) Received: from elgar.sibelius.xs4all.nl (kettenis@localhost.sibelius.xs4all.nl [127.0.0.1]) by elgar.sibelius.xs4all.nl (8.13.6/8.13.6) with ESMTP id k5MICoZF029434; Thu, 22 Jun 2006 20:12:50 +0200 (CEST) Received: (from kettenis@localhost) by elgar.sibelius.xs4all.nl (8.13.6/8.13.6/Submit) id k5MICoV7025706; Thu, 22 Jun 2006 20:12:50 +0200 (CEST) Date: Thu, 22 Jun 2006 18:13:00 -0000 Message-Id: <200606221812.k5MICoV7025706@elgar.sibelius.xs4all.nl> From: Mark Kettenis To: drow@false.org CC: gdb-patches@sourceware.org In-reply-to: <20060622033609.GA28010@nevyn.them.org> (message from Daniel Jacobowitz on Wed, 21 Jun 2006 23:36:09 -0400) Subject: Re: [rfc] Allow xfer_partial to signal EOF out of band References: <20060622033609.GA28010@nevyn.them.org> Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-06/txt/msg00326.txt.bz2 > Date: Wed, 21 Jun 2006 23:36:09 -0400 > From: Daniel Jacobowitz > > This patch adds a mechanism for to_xfer_partial to signal that it's done. > I didn't implement the new mechanism for any other targets besides remote; > it could easily be done for e.g. procfs_read_auxv, but the turnaround time > is such that it's not a big deal either way. For the remote protocol, > where there's an extra round trip to the remote link, I set *no_more if > the target tells me to. I don't like this at all. I think target_read_partial already has enough arguments. And having read-like function calls return zero on EOF is a well-established practice. > Any comments on this? Otherwise, I'll commit it after qXfer:auxv:read. > This is the patch which actually saves one packet whenever a remote object > is transferred. Does that really impact performance? If it does, I think you should add some state to the remote protocol and use that to prevent it from sending a packet. Mark