From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27849 invoked by alias); 10 Jun 2006 23:52:30 -0000 Received: (qmail 27790 invoked by uid 22791); 10 Jun 2006 23:52:27 -0000 X-Spam-Check-By: sourceware.org Received: from colibri.its.uu.se (HELO colibri.its.uu.se) (130.238.4.154) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sat, 10 Jun 2006 23:52:21 +0000 Received: by colibri.its.uu.se (Postfix, from userid 211) id 1B3E86E0; Sun, 11 Jun 2006 01:52:19 +0200 (DFT) Received: from colibri.its.uu.se(127.0.0.1) by colibri.its.uu.se via virus-scan id s14345; Sun, 11 Jun 06 01:52:14 +0200 Received: from Psilocybe.Update.UU.SE (Psilocybe.Update.UU.SE [130.238.19.25]) by colibri.its.uu.se (Postfix) with ESMTP id E2A38366; Sun, 11 Jun 2006 01:52:13 +0200 (DFT) Received: by Psilocybe.Update.UU.SE (Postfix, from userid 30270) id ABBC544005; Sun, 11 Jun 2006 01:52:13 +0200 (CEST) From: "Alfred M. Szmidt" To: Daniel Jacobowitz CC: gdb-patches@sourceware.org In-reply-to: <20060610233548.GA10491@nevyn.them.org> (message from Daniel Jacobowitz on Sat, 10 Jun 2006 19:35:48 -0400) Subject: Re: Fix GNU build Reply-to: ams@gnu.org References: <20060610214554.DC67F44004@Psilocybe.Update.UU.SE> <20060610233548.GA10491@nevyn.them.org> Message-Id: <20060610235213.ABBC544005@Psilocybe.Update.UU.SE> Date: Sat, 10 Jun 2006 23:52:00 -0000 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-06/txt/msg00135.txt.bz2 > Is anyone maintaining the Hurdy bits in GDB? No, I don't think so. Where does one go to volunteer? > - error (_("Can't run single thread id %d: no such thread!")); > + error (_("Can't run single thread id: no such thread!"), inf->pid); Er, is that right? No, it isn't. Thanks for spotting it, a bit late on my side. Here is a new patch. 2006-06-10 Alfred M. Szmidt * gnu-nat.c: Undefine _process_user_ before including . (gnu_resume): Supply missing argument to error(). (gnu_read_inferior): Add extra parenthesis around arithmetic expression to silence warnings from GCC. (gnu_write_inferior): Likewise. (gnu_xfer_memory): Changed type of MYADDR to `gdb_byte *'. Index: gnu-nat.c =================================================================== RCS file: /cvs/src/src/gdb/gnu-nat.c,v retrieving revision 1.40 diff -u -r1.40 gnu-nat.c --- gnu-nat.c 11 May 2006 19:37:52 -0000 1.40 +++ gnu-nat.c 10 Jun 2006 21:37:31 -0000 @@ -45,6 +45,9 @@ #include #include #include +/* Defined by , but we need forward declarations from + as well, which the same name. */ +#undef _process_user_ #include #include #include @@ -1978,7 +1981,7 @@ { struct proc *thread = inf_tid_to_thread (inf, PIDGET (tid)); if (!thread) - error (_("Can't run single thread id %d: no such thread!")); + error (_("Can't run single thread id %d: no such thread!"), inf->pid); inf_debug (inf, "running one thread: %d/%d", inf->pid, thread->tid); inf_set_threads_resume_sc (inf, thread, 0); } @@ -2257,7 +2260,7 @@ if (err) return 0; - err = hurd_safe_copyin (myaddr, (void *) addr - low_address + copied, length); + err = hurd_safe_copyin (myaddr, (void *) (addr - low_address + copied), length); if (err) { warning (_("Read from inferior faulted: %s"), safe_strerror (err)); @@ -2312,7 +2315,7 @@ deallocate++; - err = hurd_safe_copyout ((void *) addr - low_address + copied, + err = hurd_safe_copyout ((void *) (addr - low_address + copied), myaddr, length); CHK_GOTO_OUT ("Write to inferior faulted", err); @@ -2445,7 +2448,8 @@ /* Return 0 on failure, number of bytes handled otherwise. TARGET is ignored. */ static int -gnu_xfer_memory (CORE_ADDR memaddr, char *myaddr, int len, int write, +gnu_xfer_memory (CORE_ADDR memaddr, gdb_byte *myaddr, + int len, int write, struct mem_attrib *attrib, struct target_ops *target) {