From: "Alfred M. Szmidt" <ams@gnu.org>
To: gdb-patches@sourceware.org
Subject: Fix GNU build
Date: Sat, 10 Jun 2006 21:46:00 -0000 [thread overview]
Message-ID: <20060610214554.DC67F44004@Psilocybe.Update.UU.SE> (raw)
Hey,
gdb changed how it handles warnings a while back, and the gnu-nat.c
code hasn't really been maintained that well over the years so it
caused some minor breakage there. Here is a patch that fixes all
remaining errors and warnings.
Is anyone maintaining the Hurdy bits in GDB?
2006-06-10 Alfred M. Szmidt <root@gnu.org>
* gnu-nat.c: Undefine _process_user_ before including
<hurd/process_request.h>.
(gnu_resume): Supply missing argument to error().
(gnu_read_inferior): Add extra parenthesis around arithmetic
expression to silence warnings from GCC.
(gnu_write_inferior): Likewise.
(gnu_xfer_memory): Changed type of MYADDR to `gdb_byte *'.
Index: gnu-nat.c
===================================================================
RCS file: /cvs/src/src/gdb/gnu-nat.c,v
retrieving revision 1.40
diff -u -r1.40 gnu-nat.c
--- gnu-nat.c 11 May 2006 19:37:52 -0000 1.40
+++ gnu-nat.c 10 Jun 2006 21:37:31 -0000
@@ -45,6 +45,9 @@
#include <hurd/msg.h>
#include <hurd/msg_request.h>
#include <hurd/process.h>
+/* Defined by <hurd/process.h>, but we need forward declarations from
+ <hurd/process_request.h> as well, which the same name. */
+#undef _process_user_
#include <hurd/process_request.h>
#include <hurd/signal.h>
#include <hurd/sigpreempt.h>
@@ -1978,7 +1981,7 @@
{
struct proc *thread = inf_tid_to_thread (inf, PIDGET (tid));
if (!thread)
- error (_("Can't run single thread id %d: no such thread!"));
+ error (_("Can't run single thread id: no such thread!"), inf->pid);
inf_debug (inf, "running one thread: %d/%d", inf->pid, thread->tid);
inf_set_threads_resume_sc (inf, thread, 0);
}
@@ -2257,7 +2260,7 @@
if (err)
return 0;
- err = hurd_safe_copyin (myaddr, (void *) addr - low_address + copied, length);
+ err = hurd_safe_copyin (myaddr, (void *) (addr - low_address + copied), length);
if (err)
{
warning (_("Read from inferior faulted: %s"), safe_strerror (err));
@@ -2312,7 +2315,7 @@
deallocate++;
- err = hurd_safe_copyout ((void *) addr - low_address + copied,
+ err = hurd_safe_copyout ((void *) (addr - low_address + copied),
myaddr, length);
CHK_GOTO_OUT ("Write to inferior faulted", err);
@@ -2445,7 +2448,8 @@
/* Return 0 on failure, number of bytes handled otherwise. TARGET
is ignored. */
static int
-gnu_xfer_memory (CORE_ADDR memaddr, char *myaddr, int len, int write,
+gnu_xfer_memory (CORE_ADDR memaddr, gdb_byte *myaddr,
+ int len, int write,
struct mem_attrib *attrib,
struct target_ops *target)
{
next reply other threads:[~2006-06-10 21:46 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-10 21:46 Alfred M. Szmidt [this message]
2006-06-10 21:54 ` Alfred M. Szmidt
2006-06-10 23:35 ` Daniel Jacobowitz
2006-06-10 23:52 ` Alfred M. Szmidt
2006-06-11 0:00 ` Daniel Jacobowitz
2006-06-11 11:35 ` Alfred M. Szmidt
2006-06-14 0:34 ` Jim Blandy
2006-06-15 12:41 ` Alfred M. Szmidt
2006-07-12 17:37 ` Daniel Jacobowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060610214554.DC67F44004@Psilocybe.Update.UU.SE \
--to=ams@gnu.org \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox