Re: [patch] Crashed cross gdb/MinGW host

[Christopher Faylor <me@cgf.cx>]

On Sat, Jun 10, 2006 at 02:25:07PM -0400, Daniel Jacobowitz wrote:
>On Fri, May 19, 2006 at 02:52:57PM -0400, Christopher Faylor wrote:
>> On Fri, May 19, 2006 at 06:47:04PM +0900, Masaki Muranaka wrote:
>> >My sh-elf-gdb on MinGW host was crashed when I tried to debug using the
>> >serial connection.  Here is a patch.
>> >
>> >It's possible the another plan to remove writefds check.  There is no
>> >support yet for writefds.
>> 
>> If this is truly supposed to be an emulation of the system select(), I
>> think it would make sense to check both !readfds and !writefds.
>
>Sorry for letting this sit so long.  I just encountered this bug today. 
>I think I tested console and pipe when I last touched this code
>but failed to test ser-base.
>
>The underlying problem is actually different.  The code looks like
>this:
>      if (!FD_ISSET (fd, readfds) && !FD_ISSET (fd, writefds))
>        continue;
>
>      if (FD_ISSET (fd, readfds))
>	...
>
>      if (FD_ISSET (fd, exceptfds))
>	...
>
>See the mismatch? :-(

I saw it and was wondering about it.  I'm glad to see consistency restored.

:-)

cgf