From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18066 invoked by alias); 8 Jun 2006 23:59:16 -0000 Received: (qmail 18057 invoked by uid 22791); 8 Jun 2006 23:59:16 -0000 X-Spam-Check-By: sourceware.org Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Thu, 08 Jun 2006 23:59:14 +0000 Received: from drow by nevyn.them.org with local (Exim 4.54) id 1FoUPA-0001ia-OF; Thu, 08 Jun 2006 19:59:12 -0400 Date: Thu, 08 Jun 2006 23:59:00 -0000 From: Daniel Jacobowitz To: Jim Blandy Cc: Julian Brown , gdb-patches@sourceware.org Subject: Re: [PATCH] Accept DWARF 3-format debug info Message-ID: <20060608235912.GA6545@nevyn.them.org> Mail-Followup-To: Jim Blandy , Julian Brown , gdb-patches@sourceware.org References: <4488A920.9090705@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.11+cvs20060403 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-06/txt/msg00084.txt.bz2 On Thu, Jun 08, 2006 at 04:25:42PM -0700, Jim Blandy wrote: > I think this patch is right. It's true that GDB doesn't support all > of DWARF 3, but GDB's general philosophy is to garner as much > information as it can, and punt the rest, which works well with > DWARF's philosophy. So GDB shouldn't just punt entire compilation > units because they're marked as DWARF 3. I agree. There seems to be one structural change in .debug_info tied to the version number (there's also the initial lengths, but we already support that). That is: References that use the attribute form DW_FORM_ref_addr are specified to be four bytes in the DWARF 32-bit format and eight bytes in the DWARF 64-bit format, while DWARF Version 2 specifies that such references have the same size as anaddress on the target system (see Sections 7.4 and 7.5.4). I see two places (skip_one_die and read_attribute_value) that are affected. So, this should be an easy item to fix. -- Daniel Jacobowitz CodeSourcery