From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29710 invoked by alias); 8 Jun 2006 18:41:49 -0000 Received: (qmail 29692 invoked by uid 22791); 8 Jun 2006 18:41:48 -0000 X-Spam-Check-By: sourceware.org Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Thu, 08 Jun 2006 18:41:46 +0000 Received: from drow by nevyn.them.org with local (Exim 4.54) id 1FoPRm-0007EZ-Rp; Thu, 08 Jun 2006 14:41:34 -0400 Date: Thu, 08 Jun 2006 18:41:00 -0000 From: Daniel Jacobowitz To: Anton Blanchard Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Fix powerpc 64bit backtrace code Message-ID: <20060608184134.GD26368@nevyn.them.org> Mail-Followup-To: Anton Blanchard , gdb-patches@sourceware.org References: <20060602023824.GC1736@krispykreme> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20060602023824.GC1736@krispykreme> User-Agent: Mutt/1.5.11+cvs20060403 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-06/txt/msg00075.txt.bz2 On Fri, Jun 02, 2006 at 12:38:24PM +1000, Anton Blanchard wrote: > Knowing this I looked through the backtrace code and it looks like the > fallback is incorrect. If we fail to determine the stack layout > accurately we should make a guess based on the ABI. It turns out > tdep->lr_frame_offset was created for this purpose, but isnt used > anywhere. Yep. It was used, but that code is long gone; I think I added the fallback you're fixing, but I didn't know about lr_frame_offset. The patch looks right. Do you have write access to src? If so, you can check this in and add your name to write-after-approval in MAINTAINERS. Or I can check it in for you; just let me know which. -- Daniel Jacobowitz CodeSourcery