Re: [RFA/6.5 branch] make -Werror no longer the default

Joel Brobecker
2006-06-02T19:14:40Z

Hello maintainers,

I was wondering if this patch could be reviewed in the near future,
because I'm waiting for this to be approved before creating the first
pre-release snapshot...

Thanks!

On Thu, May 25, 2006 at 09:27:35AM -0700, Joel Brobecker wrote:
> Hello,
>
> As discussed previously, the attached patch removes the section
> of the configure script that makes -Werror the default. This is for
> the GDB 6.5 branch only; and the intent is to avoid causing a build
> failure for users who might build the release on systems where all
> warnings haven't been eliminated yet.
>
> 2006-05-25 Joel Brobecker <brobecker@adacore.com>
>
> * configure.ac: -Werror is no longer enabled by default.
> * configure: Regenerate.
>
> Tested on x86-linux by configure+build a first time before change,
> noticing -Werror in the compilation commands, then modifying configure,
> and seeing the absence of -Werror during the re-build.
>
> OK to apply?
>
> Thanks,
> --
> Joel

> Index: configure.ac
> ===================================================================
> RCS file: /cvs/src/src/gdb/configure.ac,v
> retrieving revision 1.31
> diff -u -p -r1.31 configure.ac
> --- configure.ac 29 Mar 2006 22:58:54 -0000 1.31
> +++ configure.ac 25 May 2006 16:22:31 -0000
> @@ -1122,11 +1122,6 @@ AC_ARG_ENABLE(werror,
> *) AC_MSG_ERROR(bad value ${enableval} for --enable-werror) ;;
> esac])
>
> -# Enable -Werror by default when using gcc
> -if test "${GCC}" = yes -a -z "${ERROR_ON_WARNING}" ; then
> - ERROR_ON_WARNING=yes
> -fi
> -
> WERROR_CFLAGS=""
> if test "${ERROR_ON_WARNING}" = yes ; then
> WERROR_CFLAGS="-Werror"

--
Joel