From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6939 invoked by alias); 2 Jun 2006 19:14:40 -0000 Received: (qmail 6931 invoked by uid 22791); 2 Jun 2006 19:14:39 -0000 X-Spam-Check-By: sourceware.org Received: from nile.gnat.com (HELO nile.gnat.com) (205.232.38.5) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 02 Jun 2006 19:14:37 +0000 Received: from localhost (localhost [127.0.0.1]) by filtered-nile.gnat.com (Postfix) with ESMTP id 48A7848CD9F for ; Fri, 2 Jun 2006 15:14:34 -0400 (EDT) Received: from nile.gnat.com ([127.0.0.1]) by localhost (nile.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 05804-01-8 for ; Fri, 2 Jun 2006 15:14:34 -0400 (EDT) Received: from takamaka.act-europe.fr (s142-179-108-108.bc.hsia.telus.net [142.179.108.108]) by nile.gnat.com (Postfix) with ESMTP id B68FB48CBDF for ; Fri, 2 Jun 2006 15:14:33 -0400 (EDT) Received: by takamaka.act-europe.fr (Postfix, from userid 507) id C525D47E7F; Fri, 2 Jun 2006 12:14:32 -0700 (PDT) Date: Fri, 02 Jun 2006 19:14:00 -0000 From: Joel Brobecker To: gdb-patches@sources.redhat.com Subject: Re: [RFA/6.5 branch] make -Werror no longer the default Message-ID: <20060602191432.GA1056@adacore.com> References: <20060525162735.GI1309@adacore.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20060525162735.GI1309@adacore.com> User-Agent: Mutt/1.4i Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-06/txt/msg00021.txt.bz2 Hello maintainers, I was wondering if this patch could be reviewed in the near future, because I'm waiting for this to be approved before creating the first pre-release snapshot... Thanks! On Thu, May 25, 2006 at 09:27:35AM -0700, Joel Brobecker wrote: > Hello, > > As discussed previously, the attached patch removes the section > of the configure script that makes -Werror the default. This is for > the GDB 6.5 branch only; and the intent is to avoid causing a build > failure for users who might build the release on systems where all > warnings haven't been eliminated yet. > > 2006-05-25 Joel Brobecker > > * configure.ac: -Werror is no longer enabled by default. > * configure: Regenerate. > > Tested on x86-linux by configure+build a first time before change, > noticing -Werror in the compilation commands, then modifying configure, > and seeing the absence of -Werror during the re-build. > > OK to apply? > > Thanks, > -- > Joel > Index: configure.ac > =================================================================== > RCS file: /cvs/src/src/gdb/configure.ac,v > retrieving revision 1.31 > diff -u -p -r1.31 configure.ac > --- configure.ac 29 Mar 2006 22:58:54 -0000 1.31 > +++ configure.ac 25 May 2006 16:22:31 -0000 > @@ -1122,11 +1122,6 @@ AC_ARG_ENABLE(werror, > *) AC_MSG_ERROR(bad value ${enableval} for --enable-werror) ;; > esac]) > > -# Enable -Werror by default when using gcc > -if test "${GCC}" = yes -a -z "${ERROR_ON_WARNING}" ; then > - ERROR_ON_WARNING=yes > -fi > - > WERROR_CFLAGS="" > if test "${ERROR_ON_WARNING}" = yes ; then > WERROR_CFLAGS="-Werror" -- Joel