From: Joel Brobecker <brobecker@adacore.com>
To: gdb-patches@sources.redhat.com
Subject: [RFA/6.5 branch] make -Werror no longer the default
Date: Thu, 25 May 2006 17:22:00 -0000 [thread overview]
Message-ID: <20060525162735.GI1309@adacore.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 693 bytes --]
Hello,
As discussed previously, the attached patch removes the section
of the configure script that makes -Werror the default. This is for
the GDB 6.5 branch only; and the intent is to avoid causing a build
failure for users who might build the release on systems where all
warnings haven't been eliminated yet.
2006-05-25 Joel Brobecker <brobecker@adacore.com>
* configure.ac: -Werror is no longer enabled by default.
* configure: Regenerate.
Tested on x86-linux by configure+build a first time before change,
noticing -Werror in the compilation commands, then modifying configure,
and seeing the absence of -Werror during the re-build.
OK to apply?
Thanks,
--
Joel
[-- Attachment #2: werror.diff --]
[-- Type: text/plain, Size: 632 bytes --]
Index: configure.ac
===================================================================
RCS file: /cvs/src/src/gdb/configure.ac,v
retrieving revision 1.31
diff -u -p -r1.31 configure.ac
--- configure.ac 29 Mar 2006 22:58:54 -0000 1.31
+++ configure.ac 25 May 2006 16:22:31 -0000
@@ -1122,11 +1122,6 @@ AC_ARG_ENABLE(werror,
*) AC_MSG_ERROR(bad value ${enableval} for --enable-werror) ;;
esac])
-# Enable -Werror by default when using gcc
-if test "${GCC}" = yes -a -z "${ERROR_ON_WARNING}" ; then
- ERROR_ON_WARNING=yes
-fi
-
WERROR_CFLAGS=""
if test "${ERROR_ON_WARNING}" = yes ; then
WERROR_CFLAGS="-Werror"
next reply other threads:[~2006-05-25 16:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-25 17:22 Joel Brobecker [this message]
2006-06-02 19:14 ` Joel Brobecker
2006-06-02 19:16 ` Daniel Jacobowitz
2006-06-02 19:39 ` Jim Blandy
2006-06-02 21:13 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060525162735.GI1309@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox