From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25995 invoked by alias); 17 May 2006 00:45:32 -0000 Received: (qmail 25987 invoked by uid 22791); 17 May 2006 00:45:32 -0000 X-Spam-Check-By: sourceware.org Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Wed, 17 May 2006 00:45:30 +0000 Received: from drow by nevyn.them.org with local (Exim 4.54) id 1FgAAJ-00054R-Cy; Tue, 16 May 2006 20:45:27 -0400 Date: Wed, 17 May 2006 01:28:00 -0000 From: Daniel Jacobowitz To: Nick Roberts Cc: gdb-patches@sources.redhat.com, Vladimir Prus Subject: Re: [PATCH] -var-update [was Re: Variable objects: references formatting] Message-ID: <20060517004527.GA19347@nevyn.them.org> Mail-Followup-To: Nick Roberts , gdb-patches@sources.redhat.com, Vladimir Prus References: <17497.14121.225320.477428@farnswood.snap.net.nz> <200605041100.09748.ghost@cs.msu.su> <17497.43822.261192.673547@farnswood.snap.net.nz> <200605041610.16153.ghost@cs.msu.su> <17503.15435.371371.707494@farnswood.snap.net.nz> <20060515164605.GF28924@nevyn.them.org> <17514.26047.918241.942848@farnswood.snap.net.nz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <17514.26047.918241.942848@farnswood.snap.net.nz> User-Agent: Mutt/1.5.11+cvs20060403 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-05/txt/msg00371.txt.bz2 On Wed, May 17, 2006 at 11:52:31AM +1200, Nick Roberts wrote: > > For instance: > > > > /* The contents of VAL1 are supposed to be known. */ > > gdb_assert (!value_lazy (val1)); > > > > If val1 is the reference at this point, then we haven't checked what we > > think we have. > > Trying to interpret the code, given that val1 doesn't hold the value I > wonder why this assertion is true i.e why is value->lazy=0 even though > the value isn't in the contents field. I am not sure what you mean. !value_lazy (val1) means the contents of val1 have already been read from the target. At this point, val1 is the _reference_. Nothing is arranging to cache the value pointed to; that's what needs to happen. > > Every time my_value_equal is called its first argument comes from a > > varobj's ->value. It seems to me that if we want to properly know > > whether the varobj has changed, we'd better have read its value into > > GDB. > > Could it not doing that because GDB's value mechanism isn't working properly > for references? The value mechanism is working fine; it's varobj that does not support references. -- Daniel Jacobowitz CodeSourcery