Re: [patch] Strange stepping behaviour with ppc32 with secure PLTs

PAUL GILLIAM
2006-06-23T21:06:16Z

[-- Attachment #1: Type: text/plain, Size: 829 bytes --]

It's been more than a month, so I thought I'd try again.

I also thought I'd try the new patch tracker:

:ADDPATCH PowerPC-32:

This patch fixes a problem gdb has 'next'ing over a call to a library
function on a ppc32 target program when secure PLT's are being used. It
implements a 'GDB only solution' of the previous discussion on the
'gdb@' mailing list.

Here is that previous discussion:
http://sourceware.org/ml/gdb/2006-05/msg00154.html
and Daniel Jacobowitz's response:
http://sourceware.org/ml/gdb/2006-05/msg00155.html

Subsequent discussion on gdb-patches begins here:
http://sourceware.org/ml/gdb-patches/2006-05/msg00270.html
And peter out here:
http://sourceware.org/ml/gdb-patches/2006-05/msg00420.html

I have attached a update of the patch, now diff'ed against current
sources.

OK to commit?

-=# Paul #=-

[-- Attachment #2: keep-solib-tramp-sym.diff --]
[-- Type: text/x-patch, Size: 867 bytes --]

2006-06-23 Paul Gilliam <pgilliam@us.ibm.com>

* minsyms.c (lookup_minimal_symbol_by_pc_section): Don't ignore
minimal symbols for solib trampolines just because they're in a
different section than the PC.

Index: minsyms.c
===================================================================
RCS file: /cvs/src/src/gdb/minsyms.c,v
retrieving revision 1.45
diff -a -u -r1.45 minsyms.c
--- minsyms.c 17 Dec 2005 22:34:01 -0000 1.45
+++ minsyms.c 23 Jun 2006 20:59:34 -0000
@@ -486,6 +486,8 @@
don't fill the bfd_section member, so don't
throw away symbols on those platforms. */
&& SYMBOL_BFD_SECTION (&msymbol[hi]) != NULL
+ /* Don't ignoe symbols for solib tranpolines. */
+ && MSYMBOL_TYPE (&msymbol[hi]) != mst_solib_trampoline
&& SYMBOL_BFD_SECTION (&msymbol[hi]) != section)
--hi;