From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26625 invoked by alias); 13 May 2006 17:08:59 -0000 Received: (qmail 26616 invoked by uid 22791); 13 May 2006 17:08:58 -0000 X-Spam-Check-By: sourceware.org Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Sat, 13 May 2006 17:08:55 +0000 Received: from drow by nevyn.them.org with local (Exim 4.54) id 1Fexbm-00020p-B6; Sat, 13 May 2006 13:08:50 -0400 Date: Sat, 13 May 2006 18:53:00 -0000 From: Daniel Jacobowitz To: Mark Kettenis Cc: gdb-patches@sourceware.org Subject: Re: [RFC] Move the frame zero PC check earlier Message-ID: <20060513170850.GA7698@nevyn.them.org> Mail-Followup-To: Mark Kettenis , gdb-patches@sourceware.org References: <20060510180312.GA12606@nevyn.them.org> <200605130946.k4D9kZ2M001331@elgar.sibelius.xs4all.nl> <20060513151338.GB3721@nevyn.them.org> <200605131642.k4DGgiqa018273@elgar.sibelius.xs4all.nl> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200605131642.k4DGgiqa018273@elgar.sibelius.xs4all.nl> User-Agent: Mutt/1.5.8i X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-05/txt/msg00301.txt.bz2 I'll respond to this in more depth later; I still disagree with much of it :-) But I don't have time this moment, and I wanted to answer one particular thing: On Sat, May 13, 2006 at 06:42:44PM +0200, Mark Kettenis wrote: > > And when we've run out of useful information, the stack appears to > > end, and we're quite justified in reporting that the stack ended. > > It's quite complex enough already without reporting "but the end of > > the stack looks a little funny to me...". > > No, if a stack doesn't end properly on a platform where it should end > properly, that's useful information that should be reported to the > user. Now you've gotten me really confused. PC == 0 is the "proper" end of the stack in lots of platform ABIs; that's why the check was added to frame.c in the first place instead of leaving it in the PA-RISC specific file where it was just before it was added. That's exactly why I want to detect it: because it signals a clean end to the stack. -- Daniel Jacobowitz CodeSourcery