From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20570 invoked by alias); 13 May 2006 16:24:13 -0000 Received: (qmail 20559 invoked by uid 22791); 13 May 2006 16:24:11 -0000 X-Spam-Check-By: sourceware.org Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Sat, 13 May 2006 16:24:01 +0000 Received: from drow by nevyn.them.org with local (Exim 4.54) id 1FewuJ-0001kh-Gl; Sat, 13 May 2006 12:23:55 -0400 Date: Sat, 13 May 2006 16:43:00 -0000 From: Daniel Jacobowitz To: Gaius Mulley Cc: gdb-patches@sources.redhat.com, Joel Brobecker , Eli Zaretskii , Jim Blandy Subject: Re: [commit]: Re: Enhanced language support for Modula-2 Message-ID: <20060513162355.GA6564@nevyn.them.org> Mail-Followup-To: Gaius Mulley , gdb-patches@sources.redhat.com, Joel Brobecker , Eli Zaretskii , Jim Blandy References: <20060504153726.GA2396@nevyn.them.org> <8f2776cb0605041101u7d969e0eodde33866ac4abc41@mail.gmail.com> <874q00liyr.fsf@glam.ac.uk> <874pzyrf8l.fsf@glam.ac.uk> <87mzdosqi4.fsf@glam.ac.uk> <20060512164239.GB27234@adacore.com> <87zmhlgc0y.fsf_-_@glam.ac.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87zmhlgc0y.fsf_-_@glam.ac.uk> User-Agent: Mutt/1.5.8i X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-05/txt/msg00298.txt.bz2 On Sat, May 13, 2006 at 04:49:49PM +0100, Gaius Mulley wrote: > > Hi, > > a small note to say that I've applied the Modula-2 enhancement patches > to the gdb cvs. Many thanks for all the guidance, Hi Gaius, Great to see this in. And I see you've been working on the ChangeLog entry. But it still needs a bit of work, so here's some pointers (some of these are from the GNU Coding Standards, http://www.gnu.org/prep/standards/, others are only implicit there but GDB tries to follow them carefully). > 2006-05-09 Gaius Mulley Two spaces between name and email address in the header, please. > * gdb/m2-lang.h: added function extern prototypes for > m2_is_long_set and get_long_set_bounds. Path names should be relative to the directory containing the ChangeLog, so just "m2-lang.h". Entries should start with a capital letter and end with a period (although sentence fragments are fine). > * gm2/m2-typeprint.c: This file has been completely > replaced to reflect the Modula-2 syntax rather than call the > c_print_type function. We don't usually use explanatory sentences, just the actual changes; a bit strange, yes... > * gdb/dwarf2read.c: added ability to detect the language > Modula-2 and handle SET and CHAR types. The current version says: * gdb/dwarf2read.c: added ability to detect the language Modula-2 and handle SET and CHAR types. Again about the pathname and the explanatory sentences, but also the wrapping; what's the stray newline for? -- Daniel Jacobowitz CodeSourcery