From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10560 invoked by alias); 13 May 2006 09:28:07 -0000 Received: (qmail 10549 invoked by uid 22791); 13 May 2006 09:28:07 -0000 X-Spam-Check-By: sourceware.org Received: from sibelius.xs4all.nl (HELO sibelius.xs4all.nl) (82.92.89.47) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sat, 13 May 2006 09:28:05 +0000 Received: from elgar.sibelius.xs4all.nl (root@elgar.sibelius.xs4all.nl [192.168.0.2]) by sibelius.xs4all.nl (8.13.4/8.13.4) with ESMTP id k4D9S2YQ002278; Sat, 13 May 2006 11:28:02 +0200 (CEST) Received: from elgar.sibelius.xs4all.nl (kettenis@localhost.sibelius.xs4all.nl [127.0.0.1]) by elgar.sibelius.xs4all.nl (8.13.6/8.13.6) with ESMTP id k4D9S274020195; Sat, 13 May 2006 11:28:02 +0200 (CEST) Received: (from kettenis@localhost) by elgar.sibelius.xs4all.nl (8.13.6/8.13.6/Submit) id k4D9S1dP032654; Sat, 13 May 2006 11:28:01 +0200 (CEST) Date: Sat, 13 May 2006 09:47:00 -0000 Message-Id: <200605130928.k4D9S1dP032654@elgar.sibelius.xs4all.nl> From: Mark Kettenis To: fnf@specifix.com CC: gdb-patches@sourceware.org In-reply-to: <200605101113.50267.fnf@specifix.com> (message from Fred Fish on Wed, 10 May 2006 11:13:50 -0400) Subject: Re: [RFA] Patch to skip_prologue_using_sal() for oneline stub functions References: <200605101113.50267.fnf@specifix.com> Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-05/txt/msg00283.txt.bz2 > From: Fred Fish > Date: Wed, 10 May 2006 11:13:50 -0400 > > If a function optimizes down to a single return instruction, there is > no prologue, and skip_prologue_using_sal will return a PC that is > probably the first instruction of the next following function. In > this case, we want to return the start_pc, so that the caller will > know that it needs to run the architecture specific prologue scanner > to figure out what is going on. Hmm, this is not what the mips_skip_prologue() does. If you return START_PC, it will use *that* as the ed of the prologue. But this probably is a good thing since we really want to avoid running the architecture-specific prologue scanner if we can. That said, how does this handle functions like: void foo(void) { } or void foo (void) { return; } Did you check that?