From: Daniel Jacobowitz <drow@false.org>
To: gdb-patches@sourceware.org
Cc: ams@gnu.org
Subject: Fix Hurd build
Date: Thu, 11 May 2006 19:39:00 -0000 [thread overview]
Message-ID: <20060511193925.GA15208@nevyn.them.org> (raw)
I've committed this patch from Alfred Szmidt. Alfred, as you've noticed,
the GNATS database is not a useful way to submit patches; in addition to
being infrequently checked, it mangles unencoded attachments severely.
If you have future bugfixes for the GNU system, might I recommend posting
them to gdb-patches instead?
--
Daniel Jacobowitz
CodeSourcery
2006-05-11 Alfred M. Szmidt <ams@gnu.org>
* gnu-nat.c (inf_validate_procs): Don't use lvalue in assignments.
Index: gnu-nat.c
===================================================================
RCS file: /cvs/src/src/gdb/gnu-nat.c,v
retrieving revision 1.39
diff -u -p -r1.39 gnu-nat.c
--- gnu-nat.c 24 Jan 2006 22:09:28 -0000 1.39
+++ gnu-nat.c 11 May 2006 19:36:55 -0000
@@ -1050,7 +1050,10 @@ inf_validate_procs (struct inf *inf)
proc_debug (thread, "died!");
thread->port = MACH_PORT_NULL;
thread = _proc_free (thread); /* THREAD is dead. */
- (last ? last->next : inf->threads) = thread;
+ if (last)
+ last->next = thread;
+ else
+ inf->threads = thread;
}
}
@@ -1063,7 +1066,10 @@ inf_validate_procs (struct inf *inf)
/* THREADS[I] is a thread we don't know about yet! */
{
thread = make_proc (inf, threads[i], next_thread_id++);
- (last ? last->next : inf->threads) = thread;
+ if (last)
+ last->next = thread;
+ else
+ inf->threads = thread;
last = thread;
proc_debug (thread, "new thread: %d", threads[i]);
add_thread (pid_to_ptid (thread->tid)); /* Tell GDB's generic thread code. */
next reply other threads:[~2006-05-11 19:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-11 19:39 Daniel Jacobowitz [this message]
2006-05-11 19:42 ` Alfred M. Szmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060511193925.GA15208@nevyn.them.org \
--to=drow@false.org \
--cc=ams@gnu.org \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox