From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20592 invoked by alias); 6 May 2006 18:29:40 -0000 Received: (qmail 20583 invoked by uid 22791); 6 May 2006 18:29:39 -0000 X-Spam-Check-By: sourceware.org Received: from sibelius.xs4all.nl (HELO sibelius.xs4all.nl) (82.92.89.47) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sat, 06 May 2006 18:29:37 +0000 Received: from elgar.sibelius.xs4all.nl (root@elgar.sibelius.xs4all.nl [192.168.0.2]) by sibelius.xs4all.nl (8.13.4/8.13.4) with ESMTP id k46ISHI1012591; Sat, 6 May 2006 20:28:17 +0200 (CEST) Received: from elgar.sibelius.xs4all.nl (kettenis@localhost.sibelius.xs4all.nl [127.0.0.1]) by elgar.sibelius.xs4all.nl (8.13.6/8.13.6) with ESMTP id k46ISGgE006851; Sat, 6 May 2006 20:28:16 +0200 (CEST) Received: (from kettenis@localhost) by elgar.sibelius.xs4all.nl (8.13.6/8.13.6/Submit) id k46ISGd6009636; Sat, 6 May 2006 20:28:16 +0200 (CEST) Date: Sat, 06 May 2006 18:29:00 -0000 Message-Id: <200605061828.k46ISGd6009636@elgar.sibelius.xs4all.nl> From: Mark Kettenis To: drow@false.org CC: davem@davemloft.net, uweigand@de.ibm.com, gdb-patches@sourceware.org In-reply-to: <20060506151904.GB24060@nevyn.them.org> (message from Daniel Jacobowitz on Sat, 6 May 2006 11:19:04 -0400) Subject: Re: [committed] Fix gcore crashes on s390 References: <200605060118.k461IpKO009920@d12av02.megacenter.de.ibm.com> <20060505.183205.74231759.davem@davemloft.net> <200605060825.k468P3BX023503@elgar.sibelius.xs4all.nl> <20060506151904.GB24060@nevyn.them.org> Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-05/txt/msg00149.txt.bz2 > Date: Sat, 6 May 2006 11:19:04 -0400 > From: Daniel Jacobowitz > > On Sat, May 06, 2006 at 10:25:03AM +0200, Mark Kettenis wrote: > > Yes, targets are allowed to not implement the collect_regset functions > > if they only implement reading core dumps and don't need it for > > something else (like writing core dumps with gcore or fiddling with > > threads). All Linux targets now fall in the second category, but some > > probably think they fall in the first. So either we should: > > > > 1. Deal gracefully with the collect_regset function pointer being > > NULL. > > > > 2. Put in a gdb_assert() to check it's not null before it's used. > > > > I'm thinking that we should try option #2 for a while to get people to > > implement the functions for the other Linux targets too, just like > > Ulrich did for s390. > > Oh - sorry, I didn't see this before I approved David's change. > I'd rather not do it this way, especially with GDB 6.5 upcoming and a > lot of the Linux targets getting somewhat sporadic test coverage. > Is that all right with you? No problem. Mark