Re: [committed] Fix gcore crashes on s390

Daniel Jacobowitz
2006-05-06T01:56:49Z

On Fri, May 05, 2006 at 06:32:05PM -0700, David S. Miller wrote:
> From: "Ulrich Weigand" <uweigand@de.ibm.com>
> Date: Sat, 6 May 2006 03:18:51 +0200 (CEST)
>
> > since the switch of gcore to use regset_from_core_section, it
> > crashes on s390, because the regsets we're providing have a
> > NULL collect_regset function. Fixed by the patch below.
> >
> > Tested on s390-ibm-linux and s390x-ibm-linux.
> > Committed to mainline.
>
> Thanks for catching and fixing this.
>
> Hmmm... is this a common omission?

Apparently :-(

I see FRV has the same problem. So does HP-UX, hppa-linux, hppa-bsd,
m32r, m68k-bsd, m88k, mips64-openbsd, mips-netbsd, powerpc-linux, and
then I stopped counting. Oh, and I realize I was looking at the wrong
fields, so I probably missed some. I had no idea...

I guess we're going to have to check the collect_regset function
pointer for NULL then. David, would you mind making that change?

--
Daniel Jacobowitz
CodeSourcery