Re: [committed] Fix gcore crashes on s390

Mark Kettenis
2006-05-06T18:29:40Z

> Date: Sat, 6 May 2006 11:19:04 -0400
> From: Daniel Jacobowitz <drow@false.org>
>
> On Sat, May 06, 2006 at 10:25:03AM +0200, Mark Kettenis wrote:
> > Yes, targets are allowed to not implement the collect_regset functions
> > if they only implement reading core dumps and don't need it for
> > something else (like writing core dumps with gcore or fiddling with
> > threads). All Linux targets now fall in the second category, but some
> > probably think they fall in the first. So either we should:
> >
> > 1. Deal gracefully with the collect_regset function pointer being
> > NULL.
> >
> > 2. Put in a gdb_assert() to check it's not null before it's used.
> >
> > I'm thinking that we should try option #2 for a while to get people to
> > implement the functions for the other Linux targets too, just like
> > Ulrich did for s390.
>
> Oh - sorry, I didn't see this before I approved David's change.
> I'd rather not do it this way, especially with GDB 6.5 upcoming and a
> lot of the Linux targets getting somewhat sporadic test coverage.
> Is that all right with you?

No problem.

Mark