From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19149 invoked by alias); 6 May 2006 01:52:16 -0000 Received: (qmail 19140 invoked by uid 22791); 6 May 2006 01:52:16 -0000 X-Spam-Check-By: sourceware.org Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Sat, 06 May 2006 01:52:13 +0000 Received: from drow by nevyn.them.org with local (Exim 4.54) id 1FcBxq-0003MV-P5; Fri, 05 May 2006 21:52:10 -0400 Date: Sat, 06 May 2006 01:52:00 -0000 From: Daniel Jacobowitz To: Ulrich Weigand Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Fix spurious mi-basics.exp failures Message-ID: <20060506015210.GA12668@nevyn.them.org> Mail-Followup-To: Ulrich Weigand , gdb-patches@sourceware.org References: <200605060119.k461JWLU010082@d12av02.megacenter.de.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200605060119.k461JWLU010082@d12av02.megacenter.de.ibm.com> User-Agent: Mutt/1.5.8i X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-05/txt/msg00136.txt.bz2 On Sat, May 06, 2006 at 03:19:32AM +0200, Ulrich Weigand wrote: > Hello, > > I'm seeing some FAILs in the mi-basics test case. They're apparently > caused by the expected output regexps in some of the mi_gdb_test > statements lacking the 'serial number' the MI output lines start with. > > Most mi_gdb_test statments already contain that number, but the 202, > 203, and 208 tests don't have it. Those are exactly the tests that > fail for me. Adding the numbers fixes the test. > > Tested on s390-ibm-linux and s390x-ibm-linux. > OK for mainline? > > > ChangeLog: > > * gdb.mi/mi-basics.exp: Add missing serial number to > expected output in some mi_gdb_test statements. > * gdb.mi/mi2-basics.exp: Likewise. Are you sure you tested these in the same build tree where they were broken? I might be misremembering, but when these tests were added, I think I complained about the regexps: they fail when the srcdir is specified using a relative path, but succeed with an absolute path, or the other way round. 203-environment-directory 203^done,source-path="/big/fsf/commit/src/gdb/testsuite/gdb.mi:$cdir:$cwd" (gdb) PASS: gdb.mi/mi-basics.exp: environment-directory empty-string operation Then again, my log does seem to match your results... I don't remember these failing on this machine before. >From my previous system, an old test run passed with the anchors: 202-environment-directory /big/fsf/commit/src/gdb/testsuite/gdb.mi 202^done,source-path="/big/fsf/commit/src/gdb/testsuite/gdb.mi:$cdir:$cwd" (gdb) PASS: gdb.mi/mi-basics.exp: environment-directory arg operation 203-environment-directory 203^done,source-path="/big/fsf/commit/src/gdb/testsuite/gdb.mi:$cdir:$cwd" (gdb) PASS: gdb.mi/mi-basics.exp: environment-directory empty-string operation >From today: 202-environment-directory /space/fsf/commit/src/gdb/testsuite/gdb.mi 202^done,source-path="/space/fsf/commit/src/gdb/testsuite/gdb.mi:$cdir:$cwd" (gdb) FAIL: gdb.mi/mi-basics.exp: environment-directory arg operation 203-environment-directory 203^done,source-path="/space/fsf/commit/src/gdb/testsuite/gdb.mi:$cdir:$cwd" (gdb) FAIL: gdb.mi/mi-basics.exp: environment-directory empty-string operation Oh, I bet I know what's happened! These are the three tests that failed based on relative srcdirs or something like that. So when Bob committed fixes to the MI testsuite which added anchoring to mi_gdb_test, they probably failed for him both before and after, and that's how they were missed. Bob, does that sound reasonable? If so, the patch is OK, and thanks! -- Daniel Jacobowitz CodeSourcery