From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6231 invoked by alias); 6 May 2006 23:56:11 -0000 Received: (qmail 6223 invoked by uid 22791); 6 May 2006 23:56:10 -0000 X-Spam-Check-By: sourceware.org Received: from dsl027-180-168.sfo1.dsl.speakeasy.net (HELO sunset.davemloft.net) (216.27.180.168) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sat, 06 May 2006 23:56:08 +0000 Received: from localhost ([127.0.0.1] ident=davem) by sunset.davemloft.net with esmtp (Exim 4.60) (envelope-from ) id 1FcWcx-0003Rd-Lw; Sat, 06 May 2006 16:55:59 -0700 Date: Sat, 06 May 2006 23:56:00 -0000 Message-Id: <20060506.165559.132461580.davem@davemloft.net> To: mark.kettenis@xs4all.nl Cc: drow@false.org, uweigand@de.ibm.com, gdb-patches@sourceware.org Subject: Re: [committed] Fix gcore crashes on s390 From: "David S. Miller" In-Reply-To: <200605061828.k46ISGd6009636@elgar.sibelius.xs4all.nl> References: <200605060825.k468P3BX023503@elgar.sibelius.xs4all.nl> <20060506151904.GB24060@nevyn.them.org> <200605061828.k46ISGd6009636@elgar.sibelius.xs4all.nl> X-Mailer: Mew version 4.2.53 on Emacs 21.4 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-05/txt/msg00151.txt.bz2 From: Mark Kettenis Date: Sat, 6 May 2006 20:28:16 +0200 (CEST) > > Date: Sat, 6 May 2006 11:19:04 -0400 > > From: Daniel Jacobowitz > > > > On Sat, May 06, 2006 at 10:25:03AM +0200, Mark Kettenis wrote: > > > Yes, targets are allowed to not implement the collect_regset functions > > > if they only implement reading core dumps and don't need it for > > > something else (like writing core dumps with gcore or fiddling with > > > threads). All Linux targets now fall in the second category, but some > > > probably think they fall in the first. So either we should: > > > > > > 1. Deal gracefully with the collect_regset function pointer being > > > NULL. > > > > > > 2. Put in a gdb_assert() to check it's not null before it's used. > > > > > > I'm thinking that we should try option #2 for a while to get people to > > > implement the functions for the other Linux targets too, just like > > > Ulrich did for s390. > > > > Oh - sorry, I didn't see this before I approved David's change. > > I'd rather not do it this way, especially with GDB 6.5 upcoming and a > > lot of the Linux targets getting somewhat sporadic test coverage. > > Is that all right with you? > > No problem. I've committed my patch to check for the NULL method. Thanks.