From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2644 invoked by alias); 5 May 2006 20:29:44 -0000 Received: (qmail 2627 invoked by uid 22791); 5 May 2006 20:29:44 -0000 X-Spam-Check-By: sourceware.org Received: from sibelius.xs4all.nl (HELO sibelius.xs4all.nl) (82.92.89.47) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 05 May 2006 20:29:42 +0000 Received: from elgar.sibelius.xs4all.nl (root@elgar.sibelius.xs4all.nl [192.168.0.2]) by sibelius.xs4all.nl (8.13.4/8.13.4) with ESMTP id k45KT8q3021468; Fri, 5 May 2006 22:29:08 +0200 (CEST) Received: from elgar.sibelius.xs4all.nl (kettenis@localhost.sibelius.xs4all.nl [127.0.0.1]) by elgar.sibelius.xs4all.nl (8.13.6/8.13.6) with ESMTP id k45KT8SB013693; Fri, 5 May 2006 22:29:08 +0200 (CEST) Received: (from kettenis@localhost) by elgar.sibelius.xs4all.nl (8.13.6/8.13.6/Submit) id k45KT7T4017379; Fri, 5 May 2006 22:29:08 +0200 (CEST) Date: Fri, 05 May 2006 20:29:00 -0000 Message-Id: <200605052029.k45KT7T4017379@elgar.sibelius.xs4all.nl> From: Mark Kettenis To: pgilliam@us.ibm.com CC: drow@false.org, gdb-patches@sources.redhat.com In-reply-to: <1146860412.16180.21.camel@dufur.beaverton.ibm.com> (message from PAUL GILLIAM on Fri, 05 May 2006 13:20:12 -0700) Subject: Re: [patch] Can't build ppc32 GDB References: <1145924338.18934.45.camel@dufur.beaverton.ibm.com> <1145924593.18934.48.camel@dufur.beaverton.ibm.com> <200604251938.k3PJc9dl014571@elgar.sibelius.xs4all.nl> <1146699224.16180.4.camel@dufur.beaverton.ibm.com> <25493.192.87.1.22.1146726734.squirrel@webmail.xs4all.nl> <20060505162955.GB31029@nevyn.them.org> <200605051649.k45GnKob023219@elgar.sibelius.xs4all.nl> <1146853938.16180.11.camel@dufur.beaverton.ibm.com> <200605051954.k45JsOhL021761@elgar.sibelius.xs4all.nl> <1146860412.16180.21.camel@dufur.beaverton.ibm.com> Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-05/txt/msg00101.txt.bz2 > From: PAUL GILLIAM > Date: Fri, 05 May 2006 13:20:12 -0700 > > On Fri, 2006-05-05 at 21:54 +0200, Mark Kettenis wrote: > > > From: PAUL GILLIAM > > > Date: Fri, 05 May 2006 11:32:18 -0700 > > > > > > OK, How about this? I tried to make everyone happy :-) > > > > > > Here is an excerpt: > > > > > > #ifdef HAVE_STDINT_H > > > #include > > > #define CORE_ADDR_CAST (uintptr_t) > > > #else > > > #define CORE_ADDR_CAST (CORE_ADDR)(unsigned long) > > > #endif > > > . . . > > > last_stopped_data_address = CORE_ADDR_CAST siginfo.si_addr; > > > > > > Then when there is a gdb_stdint.h, I'll submit another patch to include > > > it and replace CORE_ADDR_CAST with just (uintptr_t). > > > > > > Ok to commit? > > > > Sorry Paul, this is silly. Just include and use uintptr_t > > unconditionally. Or use unsigned long (the extra CORE_ADDR cast isn't > > necessary) if you're really scared that someone will try to compile > > GDB on a system with glibc 2.0.x. > > Alright, I admit it is a little silly. I thought it would fit right in > with a lot of what I see on this mailing list :-) > > Anyway, I changed it as you suggested: OK to commit? Could you do me a favour, and replace: *(long *) & buf[bytes_transferred] with *(long *) &buf[bytes_transferred] ? That extra space has been there ever since the code was reindented using indent(1), but really shouldn't be there. It makes me think it's a bitwise and instead of address off operator. Otherwise, yes, ok with that change. Mark