From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6833 invoked by alias); 5 May 2006 19:48:58 -0000 Received: (qmail 6801 invoked by uid 22791); 5 May 2006 19:48:53 -0000 X-Spam-Check-By: sourceware.org Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Fri, 05 May 2006 19:48:49 +0000 Received: from drow by nevyn.them.org with local (Exim 4.54) id 1Fc6IA-0001An-FB; Fri, 05 May 2006 15:48:46 -0400 Date: Fri, 05 May 2006 19:48:00 -0000 From: Daniel Jacobowitz To: Jim Blandy Cc: Joel Brobecker , gdb-patches@sources.redhat.com Subject: Re: [RFC/RFA] Cleaner handling of character entities ? Message-ID: <20060505194846.GO31029@nevyn.them.org> Mail-Followup-To: Jim Blandy , Joel Brobecker , gdb-patches@sources.redhat.com References: <20060505182351.GK1109@adacore.com> <20060505182852.GL31029@nevyn.them.org> <20060505190625.GA1042@adacore.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.8i X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-05/txt/msg00090.txt.bz2 On Fri, May 05, 2006 at 12:40:02PM -0700, Jim Blandy wrote: > > Joel Brobecker writes: > > We would be left with: > > > > * dwarf2read.c (read_base_type): Set code to TYPE_CODE_CHAR > > for char and unsigned char types of Ada compilation units. > > * ada-lang.c (ada_is_character_type): Always return true if > > the type code is TYPE_CODE_CHAR. > > > > Would that be OK? > > Yeah, I think that sounds like the right thing. Alternatively, do we think we ought to be using TYPE_CODE_CHAR, and if so, should we try it? One possible problem: there are three times as many or so references to TYPE_CODE_INT in tdep files as there are to TYPE_CODE_CHAR so this might break argument passing for some targets for C. On those targets it would probably already be broken for Ada. -- Daniel Jacobowitz CodeSourcery